RESOLVED FIXED Bug 60499
[Qt] DumpRenderTreeQt needs an implementation of unmarkText 
https://bugs.webkit.org/show_bug.cgi?id=60499
Summary [Qt] DumpRenderTreeQt needs an implementation of unmarkText
Chang Shu
Reported 2011-05-09 12:54:37 PDT
Should help to fix editing/inserting/insert-composition-whitespace.html
Attachments
fix patch (5.54 KB, patch)
2011-05-09 13:19 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-05-09 13:19:46 PDT
Created attachment 92837 [details] fix patch
Kenneth Rohde Christiansen
Comment 2 2011-05-09 15:21:21 PDT
Comment on attachment 92837 [details] fix patch Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-)
Chang Shu
Comment 3 2011-05-09 18:26:41 PDT
Maybe, I haven't realized it yet. :) Thanks for the review. (In reply to comment #2) > (From update of attachment 92837 [details]) > Looks good. Are you going to use that confirmComposition for other tests? Because it is doing a lot more than unmarking text :-)
WebKit Commit Bot
Comment 4 2011-05-09 19:11:33 PDT
Comment on attachment 92837 [details] fix patch Clearing flags on attachment: 92837 Committed r86124: <http://trac.webkit.org/changeset/86124>
WebKit Commit Bot
Comment 5 2011-05-09 19:11:38 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-05-10 01:39:38 PDT
Guys, you should have to run layout tests before commiting and/or watch the buildbots after commiting. Please respect the rules: http://www.webkit.org/coding/contributing.html "Once you have made your changes, you need to run the regression tests, which is done via the run-webkit-tests script. All tests must pass. Patches will not be landed in the tree if they break existing layout tests." I landed a fix: http://trac.webkit.org/changeset/86137 instead of you ... :S
Note You need to log in before you can comment on or make changes to this bug.