Bug 60487 – [Qt] DRT eventSender.addTouchPoint method is not setting the start position

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Igor Trindade Oliveira]

when adding a new touch point(eventSender.addTouchPoint(x,y)). The startPos is not being set. it is necessary to create tests for bug: https://bugs.webkit.org/show_bug.cgi?id=32484

[Igor Trindade Oliveira]

Created attachment 92814 [details]
patch

Proposed Patch

[Andreas Kling]

Comment on attachment 92814 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92814&action=review

Nice catch. r- because the code is ugly. Not your fault, but let's fix it. :)

> Tools/DumpRenderTree/qt/EventSenderQt.cpp:406
>      QTouchEvent::TouchPoint point(id);
>      m_touchPoints.append(point);
>      updateTouchPoint(index, x, y);
> +    m_touchPoints[index].setStartPos(QPointF(x, y));
>      m_touchPoints[index].setState(Qt::TouchPointPressed);

This code is unnecessarily confusing, we should fix it while we're visiting. Something like:

QTouchEvent::TouchPoint point(id);
point.setPos(QPointF(x, y));
point.setStartPos(QPointF(x, y));
point.setState(Qt::TouchPointPressed);
m_touchPoints.append(point);

And of course the 'index' variable won't be needed after this cleanup.

[Igor Trindade Oliveira]

Created attachment 92835 [details]
patch

proposed patch.

[Andreas Kling]

Comment on attachment 92835 [details]
patch

r=me

[WebKit Commit Bot]

Comment on attachment 92835 [details]
patch

Clearing flags on attachment: 92835

Committed r86090: <http://trac.webkit.org/changeset/86090>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ademar Reis]

Revision r86090 cherry-picked into qtwebkit-2.2 with commit 1064adb <http://gitorious.org/webkit/qtwebkit/commit/1064adb>