Bug 60461 - Make Chromium build with strict PassOwnPtr
Summary: Make Chromium build with strict PassOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 02:04 PDT by Adam Barth
Modified: 2011-05-09 11:14 PDT (History)
6 users (show)

See Also:


Attachments
Patch (46.32 KB, patch)
2011-05-09 02:07 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.26 MB, application/zip)
2011-05-09 07:43 PDT, WebKit Review Bot
no flags Details
Patch for landing (46.32 KB, patch)
2011-05-09 09:41 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-09 02:04:58 PDT
Make Chromium build with strict PassOwnPtr
Comment 1 Adam Barth 2011-05-09 02:07:21 PDT
Created attachment 92772 [details]
Patch
Comment 2 Tony Gentilcore 2011-05-09 02:18:36 PDT
Comment on attachment 92772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92772&action=review

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:380
> +        // FIXME: Calling get here is dangerous! What if observer is freed?

This FIXME seems less benign than the others. Is there a bug open?
Comment 3 Adam Barth 2011-05-09 02:20:16 PDT
(In reply to comment #2)
> (From update of attachment 92772 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92772&action=review
> 
> > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:380
> > +        // FIXME: Calling get here is dangerous! What if observer is freed?
> 
> This FIXME seems less benign than the others. Is there a bug open?

There isn't an open bug.  I can create one, but having the FIXME in the code is probably more likely to get attention than having a bug on file...
Comment 4 Adam Barth 2011-05-09 02:20:28 PDT
(Thanks for the review.)
Comment 5 WebKit Review Bot 2011-05-09 07:43:26 PDT
Comment on attachment 92772 [details]
Patch

Attachment 92772 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8646598

New failing tests:
inspector/debugger/dom-breakpoints.html
inspector/debugger/debugger-pause-in-eval-script.html
inspector/debugger/debugger-proto-property.html
inspector/debugger/event-listener-breakpoints.html
inspector/debugger/debugger-no-nested-pause.html
inspector/debugger/debugger-pause-on-debugger-statement.html
inspector/debugger/debugger-pause-on-exception.html
inspector/debugger/xhr-breakpoints.html
inspector/debugger/debugger-step-over.html
inspector/debugger/debugger-expand-scope.html
inspector/console/console-api-on-call-frame.html
inspector/debugger/debugger-eval-while-paused.html
inspector/debugger/debugger-pause-on-breakpoint.html
inspector/debugger/debugger-step-out.html
inspector/debugger/live-edit.html
inspector/debugger/debugger-eval-on-call-frame.html
inspector/debugger/debugger-cyclic-ref.html
inspector/debugger/debugger-step-in.html
inspector/debugger/debugger-suspend-active-dom-objects.html
Comment 6 WebKit Review Bot 2011-05-09 07:43:31 PDT
Created attachment 92789 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Adam Barth 2011-05-09 09:41:54 PDT
Created attachment 92801 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2011-05-09 11:14:08 PDT
Comment on attachment 92801 [details]
Patch for landing

Clearing flags on attachment: 92801

Committed r86067: <http://trac.webkit.org/changeset/86067>
Comment 9 WebKit Commit Bot 2011-05-09 11:14:13 PDT
All reviewed patches have been landed.  Closing bug.