Bug 60443 - REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
Summary: REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: mitz
URL:
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-05-07 17:40 PDT by mitz
Modified: 2011-05-07 23:43 PDT (History)
1 user (show)

See Also:


Attachments
Reduction (323 bytes, text/html)
2011-05-07 17:41 PDT, mitz
no flags Details
The anti-squeeze logic need not apply to positioned replaced objects (21.91 KB, patch)
2011-05-07 18:22 PDT, mitz
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-05-07 17:40:29 PDT
<rdar://problem/9403055>

Inline images in iChat conversations overflow the chat bubbles, overlapping the next message.

Caused by r85499, the fix for bug 58006.
Comment 1 mitz 2011-05-07 17:41:38 PDT
Created attachment 92702 [details]
Reduction
Comment 2 mitz 2011-05-07 18:22:01 PDT
Created attachment 92705 [details]
The anti-squeeze logic need not apply to positioned replaced objects
Comment 3 WebKit Review Bot 2011-05-07 18:24:10 PDT
Attachment 92705 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/RenderBox.cpp:2019:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBox.cpp:2021:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Daniel Bates 2011-05-07 20:46:08 PDT
Comment on attachment 92705 [details]
The anti-squeeze logic need not apply to positioned replaced objects

View in context: https://bugs.webkit.org/attachment.cgi?id=92705&action=review

> Source/WebCore/ChangeLog:13
> +        doesnÕt affect the table cellÕs height).

There are weird characters for the apostrophes in this line.
Comment 5 Maciej Stachowiak 2011-05-07 23:35:02 PDT
Comment on attachment 92705 [details]
The anti-squeeze logic need not apply to positioned replaced objects

r=me
Comment 6 mitz 2011-05-07 23:43:32 PDT
Fixed in r86024. <http://trac.webkit.org/changeset/86024>