Bug 60442 - REGRESSION (r85795): platform/win/plugins/window-geometry-initialized-before-set-window.html and platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release (WebKit2 Tests)
: REGRESSION (r85795): platform/win/plugins/window-geometry-initialized-before-...
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All Windows 7
: P2 Normal
Assigned To:
:
: InRadar, LayoutTestFailure, PlatformO...
:
:
  Show dependency treegraph
 
Reported: 2011-05-07 16:58 PST by
Modified: 2011-05-10 10:53 PST (History)


Attachments
Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows (19.90 KB, patch)
2011-05-10 08:44 PST, Adam Roben (:aroben)
andersca: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


------- Comment #1 From 2011-05-07 17:58:40 PST -------
I am going to commit the expected failing results in order to get the bots green.
------- Comment #2 From 2011-05-07 18:35:18 PST -------
Committed the expected failing results in http://trac.webkit.org/changeset/86019
------- Comment #3 From 2011-05-07 18:35:44 PST -------
<rdar://problem/9403200>
------- Comment #4 From 2011-05-09 06:03:18 PST -------
Big ol' fail on my part. Thanks for cleaning up the mess, Jessie. I'll look into these failures today.
------- Comment #5 From 2011-05-09 06:55:57 PST -------
I think we can relax these tests such that they still pass in WebKit2 and would start failing if either of the bugs they are tests for were reintroduced. At this point I see no evidence that they are indicative of real-world bugs in WebKit2.
------- Comment #6 From 2011-05-10 07:55:38 PST -------
platform/win/plugins/window-geometry-initialized-before-set-window.html is easy to fix. We should just check the window's size and stop caring about its position.

platform/win/plugins/window-region-is-set-to-clip-rect.html is harder. In WebKit2, the plugin window's region won't be set until the UI process paints. But we don't have a good way to wait for that to happen, or to ensure that it happens in a certain order.
------- Comment #7 From 2011-05-10 08:32:12 PST -------
(In reply to comment #6)
> platform/win/plugins/window-region-is-set-to-clip-rect.html is harder. In WebKit2, the plugin window's region won't be set until the UI process paints. But we don't have a good way to wait for that to happen, or to ensure that it happens in a certain order.

A timer seems to work around the issue. (Lame!)
------- Comment #8 From 2011-05-10 08:44:06 PST -------
Created an attachment (id=92959) [details]
Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
------- Comment #9 From 2011-05-10 08:53:12 PST -------
Committed r86157: <http://trac.webkit.org/changeset/86157>
------- Comment #10 From 2011-05-10 10:53:27 PST -------
http://trac.webkit.org/changeset/86157 might have broken SnowLeopard Intel Release (WebKit2 Tests)
The following tests are not passing:
fast/frames/flattening/frameset-flattening-subframesets.html