Bug 60438 - Remove references to Tiger in scripts
Summary: Remove references to Tiger in scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-07 10:15 PDT by Pratik Solanki
Modified: 2011-05-07 19:57 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.86 KB, patch)
2011-05-07 10:19 PDT, Pratik Solanki
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-05-07 10:15:37 PDT
We have a number of places in the Scripts directory where we use isTiger() to check for MacOSX Tiger. We can now remove those.
Comment 1 Pratik Solanki 2011-05-07 10:19:26 PDT
Created attachment 92693 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-07 12:08:43 PDT
Comment on attachment 92693 [details]
Patch

Yay!  Thank you!
Comment 3 Pratik Solanki 2011-05-07 12:57:18 PDT
Committed r86007 :<http://trac.webkit.org/changeset/86007>
Comment 4 Simon Fraser (smfr) 2011-05-07 15:24:18 PDT
This broke a bunch of bots.
Comment 5 Daniel Bates 2011-05-07 16:10:52 PDT
(In reply to comment #4)
> This broke a bunch of bots.

Committed attempt to fix the build in changeset 86009 <http://trac.webkit.org/changeset/86009>; remove some more references to isTiger().
Comment 6 WebKit Review Bot 2011-05-07 16:10:59 PDT
http://trac.webkit.org/changeset/86007 might have broken Leopard Intel Debug (Tests)
Comment 7 Pratik Solanki 2011-05-07 19:57:56 PDT
Oops. Sorry. I didn't think old-run-webkit-tests was used. Thanks for fixing this Daniel.