Bug 60428 - NRWT: debug messages from the workers are being logged twice
Summary: NRWT: debug messages from the workers are being logged twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
: 59273 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-05-06 19:41 PDT by Dirk Pranke
Modified: 2011-05-27 18:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.17 KB, patch)
2011-05-06 19:51 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Patch (6.37 KB, patch)
2011-05-06 20:10 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-05-06 19:41:49 PDT 
NRWT: debug messages from the workers are being logged twice
Comment 1 Dirk Pranke 2011-05-06 19:51:18 PDT 
Created attachment 92680 [details]
Patch
Comment 2 Dirk Pranke 2011-05-06 20:10:26 PDT 
Created attachment 92684 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-05-08 12:51:37 PDT 
Comment on attachment 92684 [details]
Patch

OK.  We've definitely hit this with the EWS bots.  I'm not sure I understand the fix, but I like that we're fixing it...
Comment 4 Adam Barth 2011-05-08 12:56:00 PDT 
Comment on attachment 92684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92684&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:227
> +          configure_loggign  Whether a logging handler should be registered

configure_loggign => configure_logging
Comment 5 Ojan Vafai 2011-05-09 08:46:54 PDT 
Comment on attachment 92684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92684&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:328
> +            configure_logging = False
> +            if sys.platform == 'win32':
> +                # The unix multiprocessing implementation clones the
> +                # log handler configuration into the child processes,
> +                # but the win implementation doesn't.
> +                configure_logging = True

how about:
# ...
# ...
# ...
configure_logging = sys.platform == 'win32'
Comment 6 Dirk Pranke 2011-05-12 13:15:29 PDT 
*** Bug 59273 has been marked as a duplicate of this bug. ***
Comment 7 Dirk Pranke 2011-05-27 18:56:33 PDT 
Committed r87591: <http://trac.webkit.org/changeset/87591>