WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60428
NRWT: debug messages from the workers are being logged twice
https://bugs.webkit.org/show_bug.cgi?id=60428
Summary
NRWT: debug messages from the workers are being logged twice
Dirk Pranke
Reported
2011-05-06 19:41:49 PDT
NRWT: debug messages from the workers are being logged twice
Attachments
Patch
(6.17 KB, patch)
2011-05-06 19:51 PDT
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Patch
(6.37 KB, patch)
2011-05-06 20:10 PDT
,
Dirk Pranke
ojan
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2011-05-06 19:51:18 PDT
Created
attachment 92680
[details]
Patch
Dirk Pranke
Comment 2
2011-05-06 20:10:26 PDT
Created
attachment 92684
[details]
Patch
Eric Seidel (no email)
Comment 3
2011-05-08 12:51:37 PDT
Comment on
attachment 92684
[details]
Patch OK. We've definitely hit this with the EWS bots. I'm not sure I understand the fix, but I like that we're fixing it...
Adam Barth
Comment 4
2011-05-08 12:56:00 PDT
Comment on
attachment 92684
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=92684&action=review
> Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py:227 > + configure_loggign Whether a logging handler should be registered
configure_loggign => configure_logging
Ojan Vafai
Comment 5
2011-05-09 08:46:54 PDT
Comment on
attachment 92684
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=92684&action=review
> Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:328 > + configure_logging = False > + if sys.platform == 'win32': > + # The unix multiprocessing implementation clones the > + # log handler configuration into the child processes, > + # but the win implementation doesn't. > + configure_logging = True
how about: # ... # ... # ... configure_logging = sys.platform == 'win32'
Dirk Pranke
Comment 6
2011-05-12 13:15:29 PDT
***
Bug 59273
has been marked as a duplicate of this bug. ***
Dirk Pranke
Comment 7
2011-05-27 18:56:33 PDT
Committed
r87591
: <
http://trac.webkit.org/changeset/87591
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug