when we have error in test_expectation files and we don't generate any layouttest results, and then run this tool, we should error out saying that there is no result at the bot ----- chromium-win-win7: Rebaselining 2 tests: Using http://build.chromium.org/f/chromium/layout_test_results/Webkit_Win7/84500/layout-test-results.zip Traceback (most recent call last): File "../Tools/Scripts/rebaseline-chromium-webkit-tests", line 44, in <module> rebaseline_chromium_webkit_tests.main(sys.argv[1:]) File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 959, in main zip_factory, scm_obj) File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 1022, in real_main if rebaseliner.run(): File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 199, in run self._extract_and_add_new_baselines(archive_file) File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py", line 345, in _extract_and_add_new_baselines zip_namelist = zip_file.namelist() File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/common/system/zipfileset.py", line 59, in namelist self._load() File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/common/system/zipfileset.py", line 47, in _load self._temp_file, self._zip_file = self._zip_factory(self._zip_url) File "/Users/aarya/4allwebkit/webkit/Tools/Scripts/webkitpy/common/system/zipfileset.py", line 43, in _retrieve_zip_file return (temp_file, zipfile.ZipFile(temp_file)) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 698, in __init__ self._GetContents() File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 718, in _GetContents self._RealGetContents() File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 728, in _RealGetContents endrec = _EndRecData(fp) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/zipfile.py", line 189, in _EndRecData fpin.seek(-sizeEndCentDir, 2)
rebaseline-chromium-webkit-tests is obsolete now ... hopefully we don't still have this problem with webkit-patch rebaseline-expectations or webkit-patch garden-o-matic. Let me know if you want me to reopen this.