Bug 6040 - XSLT does not report errors to the user
Summary: XSLT does not report errors to the user
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 15751
  Show dependency treegraph
 
Reported: 2005-12-11 02:50 PST by Eric Seidel (no email)
Modified: 2007-10-29 10:37 PDT (History)
2 users (show)

See Also:


Attachments
proposed fix (21.11 KB, patch)
2007-10-29 09:33 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-12-11 02:50:52 PST
XSLT does not report errors to the user

See parseErrorFunc in XSLTProcessorImpl.*

I just added two testcases to catch this:

fast/xsl/xslt-mismatched-tags-in-xslt.xml  (currently produces blank output)
fast/xsl/xslt-missing-namespace-in-xslt.xml (currently parses result as html when it shouldn't)
Comment 1 Alexey Proskuryakov 2007-10-29 09:33:09 PDT
Created attachment 16936 [details]
proposed fix
Comment 2 Darin Adler 2007-10-29 09:53:33 PDT
Comment on attachment 16936 [details]
proposed fix

r=me
Comment 3 Alexey Proskuryakov 2007-10-29 10:14:07 PDT
Committed revision 27227.

Comment 4 Alexey Proskuryakov 2007-10-29 10:17:51 PDT
NB: this patch sends errors to Web Inspector console.
Comment 5 Eric Seidel (no email) 2007-10-29 10:37:08 PDT
This fix (wonderful as it is!) does not actually solve the issue this bug was originally about... so I've filed bug 15751.  The fact that this change doesn't affect any tests concerns me.  I really think we should add a test case to demonstrate XSLTProcessor writing to the console.