WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6039
Update KCanvasFiltersQuartz.mm to match style guidelines
https://bugs.webkit.org/show_bug.cgi?id=6039
Summary
Update KCanvasFiltersQuartz.mm to match style guidelines
Eric Seidel (no email)
Reported
2005-12-11 00:50:50 PST
Update KCanvasFiltersQuartz.mm to match style guidelines This is a simple patch (99% spacing changes) to make the kcanvas filter code closer match our style guidelines. I also made one small fix of a leak of CIContexts under error conditions (we were exiting early from a method which later performed cleanup).
Attachments
Code cleanup to match style guidelines (mostly spacing changes)
(41.47 KB, patch)
2005-12-11 00:52 PST
,
Eric Seidel (no email)
darin
: review+
Details
Formatted Diff
Diff
A version of the patch ignoring whitespace
(17.81 KB, patch)
2005-12-11 00:53 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2005-12-11 00:52:36 PST
Created
attachment 5025
[details]
Code cleanup to match style guidelines (mostly spacing changes)
Eric Seidel (no email)
Comment 2
2005-12-11 00:53:43 PST
Created
attachment 5026
[details]
A version of the patch ignoring whitespace
Darin Adler
Comment 3
2005-12-11 17:09:30 PST
Comment on
attachment 5025
[details]
Code cleanup to match style guidelines (mostly spacing changes) +static QString KCPreviousFilterOutputName = QString("__previousOutput__"); The above should just be: static QString KCPreviousFilterOutputName = "__previousOutput__"; r=me on this change Reading this code I see lots to comment on that has nothing to do with what the patch changes -- maybe as part of code review.
Eric Seidel (no email)
Comment 4
2005-12-12 09:25:01 PST
Oliver might hate me... hopefully this won't cause to many conflicts w/ his patches in progress.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug