Bug 60388 - Fix some unnecessary includes in headers
Summary: Fix some unnecessary includes in headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 52451
  Show dependency tree / graph
 
Reported: 2011-05-06 11:14 PDT by Tony Gentilcore
Modified: 2011-05-10 01:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.16 KB, patch)
2011-05-06 11:16 PDT, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch (29.04 KB, patch)
2011-05-09 01:27 PDT, Tony Gentilcore 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (29.52 KB, patch)
2011-05-09 01:56 PDT, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
Patch (30.39 KB, patch)
2011-05-09 02:49 PDT, Tony Gentilcore 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (31.90 KB, patch)
2011-05-09 04:13 PDT, Tony Gentilcore 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (33.98 KB, patch)
2011-05-09 05:42 PDT, Tony Gentilcore 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-05-06 11:14:05 PDT 
Fix some unnecessary includes in headers
Comment 1 Tony Gentilcore 2011-05-06 11:16:03 PDT 
Created attachment 92611 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-06 11:19:24 PDT 
Attachment 92611 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2011-05-06 11:29:45 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8601058
Comment 4 Gyuyoung Kim 2011-05-06 12:41:27 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8615056
Comment 5 WebKit Review Bot 2011-05-06 12:48:16 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8598065
Comment 6 WebKit Review Bot 2011-05-06 13:33:41 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8617046
Comment 7 WebKit Review Bot 2011-05-06 13:40:48 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8620016
Comment 8 Collabora GTK+ EWS bot 2011-05-06 14:10:09 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8620025
Comment 9 WebKit Review Bot 2011-05-06 14:32:43 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8598097
Comment 10 Daniel Bates 2011-05-06 16:16:21 PDT 
Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8608143
Comment 11 Tony Gentilcore 2011-05-07 04:06:20 PDT 
Different flags and ports end up having different transitive deps that break. I'll work on making the bots happy. Please ignore this until then.
Comment 12 Tony Gentilcore 2011-05-09 01:27:30 PDT 
Created attachment 92770 [details]
Patch
Comment 13 WebKit Review Bot 2011-05-09 01:30:03 PDT 
Attachment 92770 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Early Warning System Bot 2011-05-09 01:41:17 PDT 
Comment on attachment 92770 [details]
Patch

Attachment 92770 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8653516
Comment 15 Tony Gentilcore 2011-05-09 01:56:25 PDT 
Created attachment 92771 [details]
Patch
Comment 16 WebKit Review Bot 2011-05-09 02:01:22 PDT 
Attachment 92771 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Early Warning System Bot 2011-05-09 02:13:43 PDT 
Comment on attachment 92771 [details]
Patch

Attachment 92771 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8660480
Comment 18 WebKit Review Bot 2011-05-09 02:31:39 PDT 
Comment on attachment 92771 [details]
Patch

Attachment 92771 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8653523
Comment 19 Tony Gentilcore 2011-05-09 02:49:17 PDT 
Created attachment 92775 [details]
Patch
Comment 20 WebKit Review Bot 2011-05-09 02:51:48 PDT 
Attachment 92775 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 Early Warning System Bot 2011-05-09 03:07:13 PDT 
Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8646533
Comment 22 WebKit Review Bot 2011-05-09 03:29:16 PDT 
Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8653538
Comment 23 WebKit Review Bot 2011-05-09 03:31:20 PDT 
Comment on attachment 92770 [details]
Patch

Attachment 92770 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8652504
Comment 24 Tony Gentilcore 2011-05-09 04:13:11 PDT 
Created attachment 92778 [details]
Patch
Comment 25 WebKit Review Bot 2011-05-09 04:15:31 PDT 
Attachment 92778 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 26 WebKit Review Bot 2011-05-09 04:54:52 PDT 
Comment on attachment 92778 [details]
Patch

Attachment 92778 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8646550
Comment 27 WebKit Review Bot 2011-05-09 05:18:40 PDT 
Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8652523
Comment 28 Tony Gentilcore 2011-05-09 05:42:26 PDT 
Created attachment 92782 [details]
Patch
Comment 29 WebKit Review Bot 2011-05-09 05:44:58 PDT 
Attachment 92782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 30 WebKit Review Bot 2011-05-09 06:37:14 PDT 
Comment on attachment 92778 [details]
Patch

Attachment 92778 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8648515
Comment 31 Darin Adler 2011-05-09 09:19:09 PDT 
Comment on attachment 92782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review

Looks good. Hard to judge a patch like this except by whether everything keeps compiling!

> Source/WebCore/css/CSSFontFaceSrcValue.h:37
>  #if ENABLE(SVG_FONTS)
> -#include "SVGFontFaceElement.h"
> +class SVGFontFaceElement;
>  #endif

For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally.
Comment 32 Tony Gentilcore 2011-05-09 09:26:34 PDT 
(In reply to comment #31)
> (From update of attachment 92782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review
> 
> Looks good. Hard to judge a patch like this except by whether everything keeps compiling!
> 
> > Source/WebCore/css/CSSFontFaceSrcValue.h:37
> >  #if ENABLE(SVG_FONTS)
> > -#include "SVGFontFaceElement.h"
> > +class SVGFontFaceElement;
> >  #endif
> 
> For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally.

Thanks, I'll fix this and then land the patch in off-hours so I can fix any breakages for builds that don't have an EWS without bothering anyone.
Comment 33 Tony Gentilcore 2011-05-10 01:20:12 PDT 
Committed r86135: <http://trac.webkit.org/changeset/86135>