Bug 60388 – Fix some unnecessary includes in headers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Gentilcore]

Fix some unnecessary includes in headers

[Tony Gentilcore]

Created attachment 92611 [details]
Patch

[WebKit Review Bot]

Attachment 92611 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8601058

[Gyuyoung Kim]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8615056

[WebKit Review Bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8598065

[WebKit Review Bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8617046

[WebKit Review Bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8620016

[Collabora GTK+ EWS bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8620025

[WebKit Review Bot]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8598097

[Daniel Bates]

Comment on attachment 92611 [details]
Patch

Attachment 92611 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8608143

[Tony Gentilcore]

Different flags and ports end up having different transitive deps that break. I'll work on making the bots happy. Please ignore this until then.

[Tony Gentilcore]

Created attachment 92770 [details]
Patch

[WebKit Review Bot]

Attachment 92770 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 51 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 92770 [details]
Patch

Attachment 92770 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8653516

[Tony Gentilcore]

Created attachment 92771 [details]
Patch

[WebKit Review Bot]

Attachment 92771 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 92771 [details]
Patch

Attachment 92771 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8660480

[WebKit Review Bot]

Comment on attachment 92771 [details]
Patch

Attachment 92771 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8653523

[Tony Gentilcore]

Created attachment 92775 [details]
Patch

[WebKit Review Bot]

Attachment 92775 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8646533

[WebKit Review Bot]

Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8653538

[WebKit Review Bot]

Comment on attachment 92770 [details]
Patch

Attachment 92770 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8652504

[Tony Gentilcore]

Created attachment 92778 [details]
Patch

[WebKit Review Bot]

Attachment 92778 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 92778 [details]
Patch

Attachment 92778 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8646550

[WebKit Review Bot]

Comment on attachment 92775 [details]
Patch

Attachment 92775 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8652523

[Tony Gentilcore]

Created attachment 92782 [details]
Patch

[WebKit Review Bot]

Attachment 92782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/TextEvent.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/css/RGBColor.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/dom/ExceptionBase.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 92778 [details]
Patch

Attachment 92778 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8648515

[Darin Adler]

Comment on attachment 92782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review

Looks good. Hard to judge a patch like this except by whether everything keeps compiling!

> Source/WebCore/css/CSSFontFaceSrcValue.h:37
>  #if ENABLE(SVG_FONTS)
> -#include "SVGFontFaceElement.h"
> +class SVGFontFaceElement;
>  #endif

For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally.

[Tony Gentilcore]

(In reply to comment #31)
> (From update of attachment 92782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92782&action=review
> 
> Looks good. Hard to judge a patch like this except by whether everything keeps compiling!
> 
> > Source/WebCore/css/CSSFontFaceSrcValue.h:37
> >  #if ENABLE(SVG_FONTS)
> > -#include "SVGFontFaceElement.h"
> > +class SVGFontFaceElement;
> >  #endif
> 
> For the future, I’m not sure we need to put a forward-declaration of a class inside an #if. There is little or no harm to just declaring the name of a class unconditionally.

Thanks, I'll fix this and then land the patch in off-hours so I can fix any breakages for builds that don't have an EWS without bothering anyone.

[Tony Gentilcore]

Committed r86135: <http://trac.webkit.org/changeset/86135>