Web Inspector: move agents from InspectorAgent to InspectorController. Now InspectorAgent is a special one that creates and owns all other agents. All agents should be created and owned by InspectorController.
Created attachment 92585 [details] Patch
Created attachment 92586 [details] Patch
Comment on attachment 92586 [details] Patch Attachment 92586 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8589297
Comment on attachment 92585 [details] Patch Attachment 92585 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8605031
Created attachment 92931 [details] Patch
Comment on attachment 92931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent.
(In reply to comment #6) > (From update of attachment 92931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > > > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) > > I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent. I believe that it deserves a separate change. This one is already quite big.
(In reply to comment #6) > (From update of attachment 92931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > > > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) > > I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent. I did this in a separate change: https://bugs.webkit.org/show_bug.cgi?id=60624
Committed r86327: <http://trac.webkit.org/changeset/86327>