RESOLVED FIXED 60359
Web Inspector: move agents from InspectorAgent to InspectorController 
https://bugs.webkit.org/show_bug.cgi?id=60359
Summary Web Inspector: move agents from InspectorAgent to InspectorController
Yury Semikhatsky
Reported 2011-05-06 04:05:29 PDT
Web Inspector: move agents from InspectorAgent to InspectorController. Now InspectorAgent is a special one that creates and owns all other agents. All agents should be created and owned by InspectorController.
Attachments
Patch (46.44 KB, patch)
2011-05-06 08:29 PDT, Yury Semikhatsky 		dbates: commit-queue-
DetailsFormatted DiffDiff
Patch (46.57 KB, patch)
2011-05-06 08:44 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (46.56 KB, patch)
2011-05-10 01:54 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-05-06 08:29:24 PDT
Created attachment 92585 [details] Patch
Yury Semikhatsky
Comment 2 2011-05-06 08:44:29 PDT
Created attachment 92586 [details] Patch
WebKit Review Bot
Comment 3 2011-05-06 08:57:35 PDT
Comment on attachment 92586 [details] Patch Attachment 92586 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8589297
Daniel Bates
Comment 4 2011-05-06 10:05:56 PDT
Comment on attachment 92585 [details] Patch Attachment 92585 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8605031
Yury Semikhatsky
Comment 5 2011-05-10 01:54:51 PDT
Created attachment 92931 [details] Patch
Pavel Feldman
Comment 6 2011-05-10 10:06:12 PDT
Comment on attachment 92931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent.
Yury Semikhatsky
Comment 7 2011-05-10 23:58:27 PDT
(In reply to comment #6) > (From update of attachment 92931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > > > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) > > I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent. I believe that it deserves a separate change. This one is already quite big.
Yury Semikhatsky
Comment 8 2011-05-11 07:29:53 PDT
(In reply to comment #6) > (From update of attachment 92931 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92931&action=review > > > Source/WebCore/inspector/InspectorInstrumentation.cpp:796 > > + if (InspectorDebuggerAgent* debuggerAgent = inspectorAgent->instrumentingAgents()->inspectorDebuggerAgent()) > > I think it is time to store instrumenting agents pointer in a map within InspectorInstrumentation. It does not make sense to access it via inspectorAgent. I did this in a separate change: https://bugs.webkit.org/show_bug.cgi?id=60624
Yury Semikhatsky
Comment 9 2011-05-12 03:48:59 PDT
Committed r86327: <http://trac.webkit.org/changeset/86327>
Note You need to log in before you can comment on or make changes to this bug.