Bug 60340 - [chromium] Make IndexedDB code use WebPermissionClient API
Summary: [chromium] Make IndexedDB code use WebPermissionClient API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on: 60378
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-05 22:28 PDT by John Abd-El-Malek
Modified: 2011-05-06 10:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.94 KB, patch)
2011-05-05 22:33 PDT, John Abd-El-Malek
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-05-05 22:28:12 PDT
[chromium] Make IndexedDB code use WebPermissionClient API
Comment 1 John Abd-El-Malek 2011-05-05 22:33:56 PDT
Created attachment 92542 [details]
Patch
Comment 2 James Robinson 2011-05-05 23:14:10 PDT
Comment on attachment 92542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review

R= me. Do we have any way to test this stuff?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71
> +    if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) {

Missing space before &&
Comment 3 John Abd-El-Malek 2011-05-05 23:25:24 PDT
(In reply to comment #2)
> (From update of attachment 92542 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review
> 
> R= me. Do we have any way to test this stuff?

there aren't automated end-to-end tests afaik

> 
> > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71
> > +    if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) {
> 
> Missing space before &&

fixed
Comment 4 John Abd-El-Malek 2011-05-05 23:26:37 PDT
Committed r85919: <http://trac.webkit.org/changeset/85919>