RESOLVED FIXED 60340
[chromium] Make IndexedDB code use WebPermissionClient API 
https://bugs.webkit.org/show_bug.cgi?id=60340
Summary [chromium] Make IndexedDB code use WebPermissionClient API
John Abd-El-Malek
Reported 2011-05-05 22:28:12 PDT
[chromium] Make IndexedDB code use WebPermissionClient API
Attachments
Patch (2.94 KB, patch)
2011-05-05 22:33 PDT, John Abd-El-Malek 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2011-05-05 22:33:56 PDT
Created attachment 92542 [details] Patch
James Robinson
Comment 2 2011-05-05 23:14:10 PDT
Comment on attachment 92542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review R= me. Do we have any way to test this stuff? > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71 > + if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) { Missing space before &&
John Abd-El-Malek
Comment 3 2011-05-05 23:25:24 PDT
(In reply to comment #2) > (From update of attachment 92542 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92542&action=review > > R= me. Do we have any way to test this stuff? there aren't automated end-to-end tests afaik > > > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:71 > > + if (webView->permissionClient()&& !webView->permissionClient()->allowIndexedDB(webFrame, name, origin)) { > > Missing space before && fixed
John Abd-El-Malek
Comment 4 2011-05-05 23:26:37 PDT
Committed r85919: <http://trac.webkit.org/changeset/85919>
Note You need to log in before you can comment on or make changes to this bug.