Bug 60331 – Remove canvas usage of roundToDevicePixels

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Matthew Delaney]

roundToDevicePixels() was added in http://trac.webkit.org/changeset/14739 to canvas in order to remedy pixel cracks when at non-integral scales. This code path causes us to create clips for drawImage which causes the drawImage path to be much slower in CG. Chromium appears to ignore the method altogether by early returning from it. I don't believe it's necessary to worry about rounding to device pixels when drawing in the canvas' backing stores.

[Matthew Delaney]

Created attachment 92531 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 92531 [details]
Patch

Were all these calls to roundToDevicePixels() added at the same time? Have you looked at the history to check why each was added?

[Matthew Delaney]

Created attachment 92810 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 92810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92810&action=review

> Source/WebCore/platform/graphics/cg/ImageCG.cpp:271
> -    CGContextDrawImage(context, GraphicsContext(context).roundToDevicePixels(FloatRect(0, 0, CGImageGetWidth(image), CGImageGetHeight(image))), image);
> +    CGContextDrawImage(context, FloatRect(0, 0, CGImageGetWidth(image), CGImageGetHeight(image)), image);

The change log says "This could only affect canvases at non-integral scale factors" but that doesn't seem to be true for this change.

> Source/WebCore/platform/graphics/cg/PatternCG.cpp:43
> +    CGRect rect = FloatRect(0, 0, CGImageGetWidth(platformImage), CGImageGetHeight(platformImage));

Ditto.

[Matthew Delaney]

Created attachment 92829 [details]
Patch

[Matthew Delaney]

Committed r86085: <http://trac.webkit.org/changeset/86085>