RESOLVED FIXED 60310
update-webkit should handle Internal using a different VCS than OpenSource. 
https://bugs.webkit.org/show_bug.cgi?id=60310
Summary update-webkit should handle Internal using a different VCS than OpenSource.
Andy Estes
Reported 2011-05-05 16:18:56 PDT
update-webkit should handle Internal using a different VCS than OpenSource.
Attachments
Patch (1.55 KB, patch)
2011-05-05 16:22 PDT, Andy Estes 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2011-05-05 16:22:31 PDT
Created attachment 92492 [details] Patch
Adam Barth
Comment 2 2011-05-05 16:25:14 PDT
Comment on attachment 92492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > Tools/ChangeLog:8 > + isGit() and isSVN() cache their results, so Internal will always be Are these methods used anywhere anymore? Maybe they can be removed?
Daniel Bates
Comment 3 2011-05-05 16:28:50 PDT
Comment on attachment 92492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review OK >> Tools/ChangeLog:8 >> + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, these functions are used in svn-apply and svn-unapply.
Andy Estes
Comment 4 2011-05-05 16:29:08 PDT
(In reply to comment #2) > (From update of attachment 92492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review > > > Tools/ChangeLog:8 > > + isGit() and isSVN() cache their results, so Internal will always be > > Are these methods used anywhere anymore? Maybe they can be removed? Yes, in svn-apply, svn-unapply and commit-log-editor. They could be removed and replaced with is(SVN|Git)Directory('.'), but that might slow down these commands if they make these checks repeatedly.
Daniel Bates
Comment 5 2011-05-05 22:42:19 PDT
This was committed in changeset 85898 <http://trac.webkit.org/changeset/85898>.
Note You need to log in before you can comment on or make changes to this bug.