Bug 60310 - update-webkit should handle Internal using a different VCS than OpenSource.
Summary: update-webkit should handle Internal using a different VCS than OpenSource.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 16:18 PDT by Andy Estes
Modified: 2011-05-05 22:42 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2011-05-05 16:22 PDT, Andy Estes
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2011-05-05 16:18:56 PDT
update-webkit should handle Internal using a different VCS than OpenSource.
Comment 1 Andy Estes 2011-05-05 16:22:31 PDT
Created attachment 92492 [details]
Patch
Comment 2 Adam Barth 2011-05-05 16:25:14 PDT
Comment on attachment 92492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review

> Tools/ChangeLog:8
> +        isGit() and isSVN() cache their results, so Internal will always be

Are these methods used anywhere anymore?  Maybe they can be removed?
Comment 3 Daniel Bates 2011-05-05 16:28:50 PDT
Comment on attachment 92492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review

OK

>> Tools/ChangeLog:8
>> +        isGit() and isSVN() cache their results, so Internal will always be
> 
> Are these methods used anywhere anymore?  Maybe they can be removed?

Yes, these functions are used in svn-apply and svn-unapply.
Comment 4 Andy Estes 2011-05-05 16:29:08 PDT
(In reply to comment #2)
> (From update of attachment 92492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92492&action=review
> 
> > Tools/ChangeLog:8
> > +        isGit() and isSVN() cache their results, so Internal will always be
> 
> Are these methods used anywhere anymore?  Maybe they can be removed?

Yes, in svn-apply, svn-unapply and commit-log-editor. They could be removed and replaced with is(SVN|Git)Directory('.'), but that might slow down these commands if they make these checks repeatedly.
Comment 5 Daniel Bates 2011-05-05 22:42:19 PDT
This was committed in changeset 85898 <http://trac.webkit.org/changeset/85898>.