Bug 60297 - Add cmd line flag to chromium version of DumpRenderTree to select GraphicsContext3D implementation
Summary: Add cmd line flag to chromium version of DumpRenderTree to select GraphicsCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 14:08 PDT by Gregg Tavares
Modified: 2011-05-12 17:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2011-05-05 16:06 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (2.37 KB, patch)
2011-05-12 14:54 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2011-05-12 15:48 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2011-05-05 14:08:05 PDT 
Add cmd line flag to chromium version of DumpRenderTree to select GraphicsContext3D implementation

I'll submit a patch for this asap.
Comment 1 Gregg Tavares 2011-05-05 16:06:10 PDT 
Created attachment 92489 [details]
Patch
Comment 2 Kenneth Russell 2011-05-05 17:31:18 PDT 
Comment on attachment 92489 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92489&action=review

Looks good except for the "reviewed by" line. Please upload another version fixing that issue and we can submit it via the commit queue.

> ChangeLog:3
> +        Reviewed by Kenneth Russell

Actually you should leave this line as "Reviewed by NOBODY (OOPS)!". The tools will fill in the reviewer's name. All other lines containing OOPS need to be addressed or removed.

> ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=60297

In the future, the preferred format is:
[synopsis]
[bug ID]

but this is fine.
Comment 3 Gregg Tavares 2011-05-12 14:54:11 PDT 
Created attachment 93348 [details]
Patch
Comment 4 Kenneth Russell 2011-05-12 15:05:13 PDT 
Comment on attachment 93348 [details]
Patch

Looks good to me.
Comment 5 WebKit Review Bot 2011-05-12 15:33:42 PDT 
Comment on attachment 93348 [details]
Patch

Attachment 93348 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8689833
Comment 6 Gregg Tavares 2011-05-12 15:48:49 PDT 
Created attachment 93360 [details]
Patch
Comment 7 Kenneth Russell 2011-05-12 16:27:58 PDT 
Comment on attachment 93360 [details]
Patch

Looks like it passed the EWS bot; let's try again.
Comment 8 WebKit Commit Bot 2011-05-12 16:49:10 PDT 
The commit-queue encountered the following flaky tests while processing attachment 93348 [details]:

java/lc3/JavaObject/JavaObjectToByte-006.html bug 60333 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2011-05-12 17:19:18 PDT 
Comment on attachment 93360 [details]
Patch

Clearing flags on attachment: 93360

Committed r86403: <http://trac.webkit.org/changeset/86403>
Comment 10 WebKit Commit Bot 2011-05-12 17:19:23 PDT 
All reviewed patches have been landed.  Closing bug.