Bug 60294 – WebKit2: Docking Web Inspector doesn't respect maximum inspector size

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Brian Weinstein]

Docking the Web Inspector in WebKit2 doesn't respect the maximum inspector size (75% of the total window height).

WebKit2 doesn't use the same way of attaching and detaching as WebKit1 on Mac and Windows, and so we need to call constrainAttachedWindowHeight when we lay out the inspector and inspected view's in WebInspectorProxyMac and WebInspectorProxyWin.

<rdar://problem/9388518>

[Brian Weinstein]

Created attachment 92455 [details]
[PATCH] Fix

[Adam Roben (:aroben)]

Comment on attachment 92455 [details]
[PATCH] Fix

Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us?

[WebKit Review Bot]

Attachment 92455 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Weinstein]

(In reply to comment #2)
> (From update of attachment 92455 [details])
> Why do we need to do this calculation in WebKit? Doens't WebCore already constrain the height for us?

WebCore doesn't constrain the height when initially attaching. It constrains the height when opening attached (which we don't do - due to <rdar://problem/9353114>), and it constrains when changing the attached window height.

Doing the calculation in WebKit also allows us to handle resizing the inspector when the whole window is resized.

[Brian Weinstein]

Landed in r85874.

[WebKit Review Bot]

http://trac.webkit.org/changeset/85874 might have broken GTK Linux 32-bit Debug
The following tests are not passing:
svg/W3C-SVG-1.1/animate-elem-46-t.svg