Bug 60287 - [chromium] switch from Lucida to free fonts for Hindi and Thai
Summary: [chromium] switch from Lucida to free fonts for Hindi and Thai
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 12:13 PDT by Tony Chang
Modified: 2011-05-05 14:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (987.64 KB, patch)
2011-05-05 12:17 PDT, Tony Chang
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-05-05 12:13:24 PDT
[chromium] switch from Lucida to free fonts for Hindi and Thai
Comment 1 Tony Chang 2011-05-05 12:17:50 PDT
Created attachment 92442 [details]
Patch
Comment 2 Tony Chang 2011-05-05 12:19:35 PDT
Adam, this change will require that you install ttf-thai-tlwg on your ews testing bot.
Comment 3 James Simonsen 2011-05-05 12:36:34 PDT
This will be nice!

There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass?
Comment 4 Tony Chang 2011-05-05 12:48:20 PDT
(In reply to comment #3)
> This will be nice!
> 
> There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass?

All the svg tests seem to pass for me with this change (hardy32 and lucid64).  I'm not sure why; fontconfig is magic to me.
Comment 5 Adam Barth 2011-05-05 13:26:12 PDT
Comment on attachment 92442 [details]
Patch

I'm R+ing this patch out of pure excitement.
Comment 6 Tony Chang 2011-05-05 13:50:17 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > There are a couple of svg tests that explicitly call out lucida sans though. Do those still pass?
> 
> All the svg tests seem to pass for me with this change (hardy32 and lucid64).  I'm not sure why; fontconfig is magic to me.

grepping through the svg tests, I see LucidaSansUnicode, "Lucida Sans Unicode", Lucida Grande, and Lucida Console.  None of these match Lucida Sans, so we weren't using Lucida in any of the svg tests.
Comment 7 Tony Chang 2011-05-05 14:26:45 PDT
Committed r85879: <http://trac.webkit.org/changeset/85879>