Bug 60271 - Web Inspector: move double click handling from TextEditor to SourceFrame.
Summary: Web Inspector: move double click handling from TextEditor to SourceFrame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 08:44 PDT by Pavel Podivilov
Modified: 2011-05-16 03:15 PDT (History)
10 users (show)

See Also:


Attachments
Patch. (9.27 KB, patch)
2011-05-05 08:48 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-05-05 08:44:45 PDT
It is SourceFrame's responsibility to check if content is editable and
to configure TextEditor component (e.g. set editable range) when user
tries to initiate editing.
Comment 1 Pavel Podivilov 2011-05-05 08:48:23 PDT
Created attachment 92422 [details]
Patch.
Comment 2 Pavel Podivilov 2011-05-05 08:49:12 PDT
Also renamed two delegate's methods:
startEditing -> beforeTextChanged
endEditing -> afterTextChanged
Comment 3 Pavel Podivilov 2011-05-16 03:15:39 PDT
Committed r86552: <http://trac.webkit.org/changeset/86552>