RESOLVED INVALID 60268
Calling LayoutTestController.dumpAsText() once makes it impossible to have a tree dump later 
https://bugs.webkit.org/show_bug.cgi?id=60268
Summary Calling LayoutTestController.dumpAsText() once makes it impossible to have a ...
Philippe Normand
Reported 2011-05-05 08:30:38 PDT
My use-case is this: - include media-file.js - include video-test.js (=> calls LTC.dumpAsText()) - in my test I want a tree dump I'm screwed because dumpAsTextCallback() calls controller->setDumpAsText(true) and there's no dumpAsTree() method. So 2 solutions: - add dumpAsTree() - make dumpAsText() take 2 optional arguments, one exists already so the 60 tests using that require a small update I'll try with first solution ;)
Attachments
proposed patch (3.07 KB, patch)
2011-05-05 08:45 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (5.16 KB, patch)
2011-05-05 09:09 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (5.22 KB, patch)
2011-05-06 01:27 PDT, Philippe Normand 		abarth: review-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-05-05 08:45:11 PDT
Created attachment 92421 [details] proposed patch
Philippe Normand
Comment 2 2011-05-05 09:05:06 PDT
Forgot WKTR change, will send a new patch
Philippe Normand
Comment 3 2011-05-05 09:09:09 PDT
Created attachment 92425 [details] proposed patch
Philippe Normand
Comment 4 2011-05-06 01:27:59 PDT
Created attachment 92561 [details] proposed patch
Eric Seidel (no email)
Comment 5 2011-05-11 20:11:06 PDT
I'm confused by this change. Why do we need this?
Adam Barth
Comment 6 2011-05-11 21:00:34 PDT
Comment on attachment 92561 [details] proposed patch I'd just fix the test scripts to not box you into this corner. We've got 20k tests without needing this feature. I suspect we don't really need it.
Philippe Normand
Comment 7 2011-05-12 01:16:08 PDT
Ok then... I'll move the function I needed from video-test.js to a dedicated file.
Note You need to log in before you can comment on or make changes to this bug.