Bug 60263 - Web Inspector: fix source mapping for formatted scripts.
Summary: Web Inspector: fix source mapping for formatted scripts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 05:08 PDT by Pavel Podivilov
Modified: 2011-05-13 10:27 PDT (History)
10 users (show)

See Also:

Attachments
Patch. (13.49 KB, patch)
2011-05-05 05:09 PDT, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-05-05 05:08:33 PDT 
Web Inspector: fix source mapping for formatted scripts.

Source mapping is broken for script chunks that are already formatted at the beginning and at the end of the script.
Comment 1 Pavel Podivilov 2011-05-05 05:09:29 PDT 
Created attachment 92404 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-05-13 04:40:58 PDT 
Comment on attachment 92404 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=92404&action=review

> LayoutTests/inspector/debugger/script-formatter.html:69
> +                testMapping("function");

Can we just dump formatted source to see the correct result?
Comment 3 Pavel Podivilov 2011-05-13 10:24:46 PDT 
(In reply to comment #2)
> (From update of attachment 92404 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92404&action=review
> 
> > LayoutTests/inspector/debugger/script-formatter.html:69
> > +                testMapping("function");
> 
> Can we just dump formatted source to see the correct result?

This is a test for source mapping. How would dumping formatted source help us to test the mapping?
Comment 4 Pavel Podivilov 2011-05-13 10:27:41 PDT 
Committed r86443: <http://trac.webkit.org/changeset/86443>