I got a binary with v8 on EFL build. It have some issues(crashes, plugin, and so on). But I hope that v8 support make WebKit/Efl and CMAKE build system better. This is fist step to support v8.
Did you miss the attachment? If you are planning to polish this integration and make it work, I think it's ok to add the option first and clean the bugs later (with the option disabled by default). Otherwise it'll be just 1 more option that doesn't work.
(In reply to comment #1) > Did you miss the attachment? > Sorry about late answer. I am waiting my other bug(#60146). > > If you are planning to polish this integration and make it work, I think it's ok to add the option first and clean the bugs later (with the option disabled by default). Otherwise it'll be just 1 more option that doesn't work. We are planning to keep v8 version for our binary and other guys in our team are following it. Although I am not focused in javascript engine, I'll try not to be broken option if I can. Thanks.
Since #60146 is resolved, could the v8/EFL build be integrated? If a binary has already been built, maybe you could provide pointers on what was done to achieve this and I could help provide a patch for the cmake build.
(In reply to comment #3) > Since #60146 is resolved, could the v8/EFL build be integrated? No, we still have more patches, but our patches are hanging on internal review process. jaehun jung, could you create a bug? > If a binary has already been built, maybe you could provide pointers on what was done to achieve this and I could help provide a patch for the cmake build. If you already did, I think that you can upload patch because this is too old. But if you just want patch, we can provide it. Although my intial patch was out-dated, I know that jeehun has latest v8/EFL.
Created attachment 126021 [details] V8 porting patch for WebKit EFL I upload v8 porting patch for WebKit EFL. It works well. So if anyone who need to replace v8 with SFX in WebKit EFL use this patch. The build option is below $ ./Tools/Scripts/build-webkit --efl --release --cmakearg="-DJAVASCRIPT_ENGINE=V8 -DENABLE_JIT=0" Revision of libv8 is 10626 (https://v8.googlecode.com/svn/tags/3.9.3) Jaehoon.
We don't support building WebKit with V8 anymore.