Bug 60234 - Rename SelectionController to FrameSelection
: Rename SelectionController to FrameSelection
Status: RESOLVED FIXED
: WebKit
HTML Editing
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Enhancement
Assigned To:
:
:
:
: 60228
  Show dependency treegraph
 
Reported: 2011-05-04 17:56 PST by
Modified: 2011-05-05 11:20 PST (History)


Attachments
Renamed SelectionController to FrameSelection (350.45 KB, patch)
2011-05-05 00:43 PST, Ryosuke Niwa
no flags Review Patch | Details | Formatted Diff | Diff
Fixed gtk build (351.77 KB, patch)
2011-05-05 09:40 PST, Ryosuke Niwa
eric: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-04 17:56:19 PST
SelectionController isn't really a controller in the sense that it contains a selection. It does have public member functions called by various parts of WebCore to update the selection state but it really is the selection of a frame, not a mere controller of the selection.
------- Comment #1 From 2011-05-05 00:43:33 PST -------
Created an attachment (id=92383) [details]
Renamed SelectionController to FrameSelection
------- Comment #2 From 2011-05-05 07:22:08 PST -------
Attachment 92383 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8571435
------- Comment #3 From 2011-05-05 09:01:30 PST -------
Do we ultimately want to make it PageSelection?
------- Comment #4 From 2011-05-05 09:25:02 PST -------
(In reply to comment #3)
> Do we ultimately want to make it PageSelection?

No. Selection must be maintained per frame and that's what the Web expects. As far as I can tell most of states in FrameSelection must persist independent of selection in other frames.
------- Comment #5 From 2011-05-05 09:40:42 PST -------
Created an attachment (id=92427) [details]
Fixed gtk build
------- Comment #6 From 2011-05-05 10:52:04 PST -------
(From update of attachment 92427 [details])
Assuming your just renaming things and you think you managed to get all 8 build systems right. :)
------- Comment #7 From 2011-05-05 11:14:51 PST -------
Committed r85864: <http://trac.webkit.org/changeset/85864>
------- Comment #8 From 2011-05-05 11:20:26 PST -------
Thanks for the review, Eric.