You need to
before you can comment on or make changes to this bug.
SelectionController isn't really a controller in the sense that it contains a selection. It does have public member functions called by various parts of WebCore to update the selection state but it really is the selection of a frame, not a mere controller of the selection.
Created an attachment (id=92383) [details]
Renamed SelectionController to FrameSelection
Attachment 92383 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8571435
Do we ultimately want to make it PageSelection?
(In reply to comment #3)
> Do we ultimately want to make it PageSelection?
No. Selection must be maintained per frame and that's what the Web expects. As far as I can tell most of states in FrameSelection must persist independent of selection in other frames.
Created an attachment (id=92427) [details]
Fixed gtk build
(From update of attachment 92427 [details])
Assuming your just renaming things and you think you managed to get all 8 build systems right. :)
Committed r85864: <http://trac.webkit.org/changeset/85864>
Thanks for the review, Eric.