Bug 60234 - Rename SelectionController to FrameSelection
: Rename SelectionController to FrameSelection
Product: WebKit
Classification: Unclassified
Component: HTML Editing
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Enhancement
Assigned To: Ryosuke Niwa
Depends on:
Blocks: 60228
  Show dependency treegraph
Reported: 2011-05-04 17:56 PDT by Ryosuke Niwa
Modified: 2011-05-05 11:20 PDT (History)
15 users (show)

See Also:

Renamed SelectionController to FrameSelection (350.45 KB, patch)
2011-05-05 00:43 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed gtk build (351.77 KB, patch)
2011-05-05 09:40 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-04 17:56:19 PDT
SelectionController isn't really a controller in the sense that it contains a selection. It does have public member functions called by various parts of WebCore to update the selection state but it really is the selection of a frame, not a mere controller of the selection.
Comment 1 Ryosuke Niwa 2011-05-05 00:43:33 PDT
Created attachment 92383 [details]
Renamed SelectionController to FrameSelection
Comment 2 Collabora GTK+ EWS bot 2011-05-05 07:22:08 PDT
Attachment 92383 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8571435
Comment 3 Alexey Proskuryakov 2011-05-05 09:01:30 PDT
Do we ultimately want to make it PageSelection?
Comment 4 Ryosuke Niwa 2011-05-05 09:25:02 PDT
(In reply to comment #3)
> Do we ultimately want to make it PageSelection?

No. Selection must be maintained per frame and that's what the Web expects. As far as I can tell most of states in FrameSelection must persist independent of selection in other frames.
Comment 5 Ryosuke Niwa 2011-05-05 09:40:42 PDT
Created attachment 92427 [details]
Fixed gtk build
Comment 6 Eric Seidel 2011-05-05 10:52:04 PDT
Comment on attachment 92427 [details]
Fixed gtk build

Assuming your just renaming things and you think you managed to get all 8 build systems right. :)
Comment 7 Ryosuke Niwa 2011-05-05 11:14:51 PDT
Committed r85864: <http://trac.webkit.org/changeset/85864>
Comment 8 Ryosuke Niwa 2011-05-05 11:20:26 PDT
Thanks for the review, Eric.