Bug 60233 - sheriff-bot is having more exception trouble
Summary: sheriff-bot is having more exception trouble
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 17:44 PDT by Adam Barth
Modified: 2011-05-04 19:24 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.34 KB, patch)
2011-05-04 18:54 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-04 17:44:58 PDT
Updating working directory
Traceback (most recent call last):
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/bot/queueengine.py", line 96, in run
    work_item = self._delegate.next_work_item()
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py", line 69, in next_work_item
    failure_map = self._tool.buildbot.failure_map()
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 451, in failure_map
    regression_window = builder.find_blameworthy_regression_window(builder_status["build_number"])
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 202, in find_blameworthy_regression_window
    red_build = self.build(red_build_number)
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 93, in build
    build = self._fetch_build(build_number)
  File "/mnt/git/webkit-sheriff-bot/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 82, in _fetch_build
    revision=int(build_dictionary['sourceStamp']['revision']),
TypeError: int() argument must be a string or a number, not 'NoneType'
Exception while preparing queue Sleeping until 2011-05-05 00:43:22 (2 mins).
Updating working directory
Comment 1 Eric Seidel (no email) 2011-05-04 18:54:37 PDT
Created attachment 92358 [details]
Patch
Comment 2 Adam Barth 2011-05-04 19:00:41 PDT
Comment on attachment 92358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92358&action=review

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:85
> +            # Buildbot uses any nubmer other than 0 to mean fail.  Since we fetch with

nubmer => number
Comment 3 Eric Seidel (no email) 2011-05-04 19:24:13 PDT
Committed r85821: <http://trac.webkit.org/changeset/85821>