Bug 60227 - Add bundle API for making a page paint as the background of another page
Summary: Add bundle API for making a page paint as the background of another page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 16:25 PDT by Anders Carlsson
Modified: 2011-05-04 16:42 PDT (History)
0 users

See Also:

Attachments
Patch (4.71 KB, patch)
2011-05-04 16:29 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-05-04 16:25:59 PDT 
Add bundle API for making a page paint as the background of another page
Comment 1 Anders Carlsson 2011-05-04 16:29:07 PDT 
Created attachment 92343 [details]
Patch
Comment 2 Darin Adler 2011-05-04 16:35:12 PDT 
Comment on attachment 92343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92343&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:587
> +    if (m_underlayPage && m_underlayPage->mainFrame()->coreFrame()->view())
> +        m_underlayPage->mainFrame()->coreFrame()->view()->updateLayoutAndStyleIfNeededRecursive();

That’s a long common subexpression. Maybe use a local variable?
Comment 3 Anders Carlsson 2011-05-04 16:42:06 PDT 
Committed r85806: <http://trac.webkit.org/changeset/85806>