Bug 60225 - [results.html] Hide the entire table if all failures are expected
Summary: [results.html] Hide the entire table if all failures are expected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 16:05 PDT by Ojan Vafai
Modified: 2011-05-04 16:56 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.42 KB, patch)
2011-05-04 16:09 PDT, Ojan Vafai
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-05-04 16:05:14 PDT
[results.html] Hide the entire table if all failures are expected
Comment 1 Ojan Vafai 2011-05-04 16:09:55 PDT
Created attachment 92340 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-04 16:11:02 PDT
Comment on attachment 92340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92340&action=review

OK.

> LayoutTests/fast/harness/results.html:387
> +    if (globalState().results.uses_expectations_file) {

Could we do this as a helper method so that this can jsut early return instead?
Comment 3 Ojan Vafai 2011-05-04 16:56:47 PDT
Committed r85809: <http://trac.webkit.org/changeset/85809>