RESOLVED FIXED 60224
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0. 
https://bugs.webkit.org/show_bug.cgi?id=60224
Summary [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Alexis Menard (darktears)
Reported Thursday, May 5, 2011 12:01:23 AM UTC
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Attachments
Patch (3.72 KB, patch)
2011-05-04 16:05 PDT, Alexis Menard (darktears) 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 Thursday, May 5, 2011 12:05:52 AM UTC
Created attachment 92339 [details] Patch
Alexis Menard (darktears)
Comment 2 Thursday, May 5, 2011 12:06:34 AM UTC
See RenderTheme.cpp to double check what I'm saying.
Andreas Kling
Comment 3 Thursday, May 5, 2011 2:43:48 PM UTC
Comment on attachment 92339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92339&action=review Did you performance test this? > Source/WebCore/ChangeLog:9 > + but webkit already have a nullptr class if there is no c++0x support. webkit -> WebKit have -> has > Source/WebKit/qt/ChangeLog:9 > + We should use nullptr rather than 0. nullptr will be added in the new C++ standard > + but webkit already have a nullptr class if there is no c++0x support. Ditto.
Alexis Menard (darktears)
Comment 4 Thursday, May 5, 2011 3:14:34 PM UTC
Committed r85851: <http://trac.webkit.org/changeset/85851>
Note You need to log in before you can comment on or make changes to this bug.