Bug 60224 - [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Summary: [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-05-04 16:01 PDT by Alexis Menard (darktears)
Modified: 2011-05-05 07:14 PDT (History)
0 users

See Also:


Attachments
Patch (3.72 KB, patch)
2011-05-04 16:05 PDT, Alexis Menard (darktears)
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-05-04 16:01:23 PDT
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
Comment 1 Alexis Menard (darktears) 2011-05-04 16:05:52 PDT
Created attachment 92339 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-05-04 16:06:34 PDT
See RenderTheme.cpp to double check what I'm saying.
Comment 3 Andreas Kling 2011-05-05 06:43:48 PDT
Comment on attachment 92339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92339&action=review

Did you performance test this?

> Source/WebCore/ChangeLog:9
> +        but webkit already have a nullptr class if there is no c++0x support.

webkit -> WebKit
have -> has

> Source/WebKit/qt/ChangeLog:9
> +        We should use nullptr rather than 0. nullptr will be added in the new C++ standard
> +        but webkit already have a nullptr class if there is no c++0x support.

Ditto.
Comment 4 Alexis Menard (darktears) 2011-05-05 07:14:34 PDT
Committed r85851: <http://trac.webkit.org/changeset/85851>