Bug 60222 - Web Inspector: searching for node does not result in bringToFront call.
Summary: Web Inspector: searching for node does not result in bringToFront call.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 15:48 PDT by Pavel Feldman
Modified: 2011-05-05 09:38 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.61 KB, patch)
2011-05-04 15:52 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2011-05-05 07:25 PDT, Pavel Feldman
yurys: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-05-04 15:48:26 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-05-04 15:52:30 PDT
Created attachment 92335 [details]
Patch
Comment 2 Yury Semikhatsky 2011-05-05 07:13:19 PDT
Comment on attachment 92335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:285
> +    m_inspectorFrontend = frontend->inspector();

InspectorDOMAgent is not supposed to access frontends other than DOMFrontend
Comment 3 Yury Semikhatsky 2011-05-05 07:14:02 PDT
Comment on attachment 92335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92335&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:889
> +        m_inspectorFrontend->bringToFront();

This should be handled on the front-end side.
Comment 4 Pavel Feldman 2011-05-05 07:25:34 PDT
Created attachment 92414 [details]
Patch
Comment 5 Pavel Feldman 2011-05-05 09:38:45 PDT
Committed r85858: <http://trac.webkit.org/changeset/85858>