Bug 60221 – Windows build of WebKit GTK needs to be able to find SystemInfo.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Fridrich Strba]

The file Source/WebKit/gtk/webkit/webkitwebsettings.cpp includes on Windows SystemInfo.h, so add the path to this header to the

[Fridrich Strba]

Created attachment 92332 [details]
Patch

[Martin Robinson]

Comment on attachment 92332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review

Seems okay, but the ChangeLog format does not look correct.

> Source/WebCore/ChangeLog:10
> +        Add Source/WebCore/platform/win to teh paths searched
> +        for headers, since Source/WebCore/platform/win/SystemInfo.h
> +        header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
> +        on Windows.
> +        https://bugs.webkit.org/show_bug.cgi?id=60221
> +

teh -> the

The ChangeLog format should be

<bug title>
<bug url>

<description>

> Source/WebCore/ChangeLog:11
> +        No new tests. (OOPS!)

You should remove this line or, even better, replace it with a short sentence saying why tests are not necessary. :)

[Fridrich Strba]

Created attachment 92336 [details]
Patch

[Fridrich Strba]

Comment on attachment 92336 [details]
Patch

Modified changelog according to the review

[WebKit Commit Bot]

Comment on attachment 92336 [details]
Patch

Clearing flags on attachment: 92336

Committed r85815: <http://trac.webkit.org/changeset/85815>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.