Bug 60221 - Windows build of WebKit GTK needs to be able to find SystemInfo.h
Summary: Windows build of WebKit GTK needs to be able to find SystemInfo.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 15:39 PDT by Fridrich Strba
Modified: 2011-05-04 17:43 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2011-05-04 15:43 PDT, Fridrich Strba 		no flags Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2011-05-04 15:58 PDT, Fridrich Strba 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridrich Strba 2011-05-04 15:39:43 PDT 
The file Source/WebKit/gtk/webkit/webkitwebsettings.cpp includes on Windows SystemInfo.h, so add the path to this header to the
Comment 1 Fridrich Strba 2011-05-04 15:43:42 PDT 
Created attachment 92332 [details]
Patch
Comment 2 Martin Robinson 2011-05-04 15:48:40 PDT 
Comment on attachment 92332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92332&action=review

Seems okay, but the ChangeLog format does not look correct.

> Source/WebCore/ChangeLog:10
> +        Add Source/WebCore/platform/win to teh paths searched
> +        for headers, since Source/WebCore/platform/win/SystemInfo.h
> +        header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
> +        on Windows.
> +        https://bugs.webkit.org/show_bug.cgi?id=60221
> +

teh -> the

The ChangeLog format should be

<bug title>
<bug url>

<description>

> Source/WebCore/ChangeLog:11
> +        No new tests. (OOPS!)

You should remove this line or, even better, replace it with a short sentence saying why tests are not necessary. :)
Comment 3 Fridrich Strba 2011-05-04 15:58:23 PDT 
Created attachment 92336 [details]
Patch
Comment 4 Fridrich Strba 2011-05-04 15:59:00 PDT 
Comment on attachment 92336 [details]
Patch

Modified changelog according to the review
Comment 5 WebKit Commit Bot 2011-05-04 17:43:10 PDT 
Comment on attachment 92336 [details]
Patch

Clearing flags on attachment: 92336

Committed r85815: <http://trac.webkit.org/changeset/85815>
Comment 6 WebKit Commit Bot 2011-05-04 17:43:15 PDT 
All reviewed patches have been landed.  Closing bug.