Bug 60207 - Framebuffer object is being created twice
Summary: Framebuffer object is being created twice
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Igor Trindade Oliveira
Depends on:
Reported: 2011-05-04 13:36 PDT by Igor Trindade Oliveira
Modified: 2011-05-05 15:10 PDT (History)
4 users (show)

See Also:

Patch (3.68 KB, patch)
2011-05-04 13:39 PDT, Igor Trindade Oliveira
kbr: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2011-05-05 02:30 PDT, Igor Trindade Oliveira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Trindade Oliveira 2011-05-04 13:36:23 PDT
Mac, Qt and GTK implementation of DrawingBuffer class is creating the framebuffer object twice.
Comment 1 Igor Trindade Oliveira 2011-05-04 13:39:34 PDT
Created attachment 92311 [details]

Proposed patch
Comment 2 Kenneth Russell 2011-05-04 18:56:42 PDT
Comment on attachment 92311 [details]

Nice catch. Looks good.
Comment 3 WebKit Commit Bot 2011-05-04 20:26:12 PDT
Comment on attachment 92311 [details]

Rejecting attachment 92311 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2

Last 500 characters of output:
d to run "[u'git', u'svn', u'dcommit']" exit_code: 1 cwd: /Projects/CommitQueue/
Updating OpenSource
From git://git.webkit.org/WebKit
   d0efaae1..92959a5 master     -> origin/master
	M	Source/WebCore/WebCore.exp.in
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/page/EventHandler.h
	M	Source/WebCore/page/EventHandler.cpp
r85826 = 92959a51805398e4546997e7287e03c1c3b262eb (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded new_master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8552793
Comment 4 Igor Trindade Oliveira 2011-05-05 02:30:26 PDT
Created attachment 92396 [details]

Trying again.
Comment 5 Kenneth Russell 2011-05-05 13:08:57 PDT
Comment on attachment 92396 [details]

Comment 6 WebKit Commit Bot 2011-05-05 15:10:13 PDT
Comment on attachment 92396 [details]

Clearing flags on attachment: 92396

Committed r85891: <http://trac.webkit.org/changeset/85891>
Comment 7 WebKit Commit Bot 2011-05-05 15:10:22 PDT
All reviewed patches have been landed.  Closing bug.