Bug 60192 - Web Inspector: add test for shadow DOM access in the console API
Summary: Web Inspector: add test for shadow DOM access in the console API
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2011-05-04 11:44 PDT by Andrey Kosyakov
Modified: 2011-05-05 05:16 PDT (History)
9 users (show)

See Also:

patch (4.94 KB, patch)
2011-05-04 11:46 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-05-04 11:44:13 PDT
We don't expose shadow DOM to JS normally, yet now that we show it in Elements panel, it may be accessed with $0. This test so far is the only place where we assure that a JS wrapper is properly created for shadow root and other shadow nodes. This is supposed to guard against things like bug 60026
Comment 1 Andrey Kosyakov 2011-05-04 11:46:30 PDT
Created attachment 92292 [details]
Comment 2 Yury Semikhatsky 2011-05-05 03:33:25 PDT
Comment on attachment 92292 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=92292&action=review

> LayoutTests/http/tests/inspector/elements-test.js:81
> +InspectorTest.selectNode = function(node, callback)

Can you change InspectorTest.selectNodeWithId to call this method as well?

> LayoutTests/inspector/console/console-shadow-dom-access.html:25
> +        expressions.splice(0, 1);

var expression = expressions.shift()
Comment 3 Andrey Kosyakov 2011-05-05 05:16:16 PDT
Manually committed a version with yurys' suggestions at r85849: http://trac.webkit.org/changeset/85849