Bug 60191 - Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
Summary: Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-04 11:38 PDT by Chris Marrin
Modified: 2011-05-04 13:17 PDT (History)
0 users

See Also:

Attachments
Patch (1.79 KB, patch)
2011-05-04 11:41 PDT, Chris Marrin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2011-05-04 11:38:24 PDT 
PlatformCALayer ::replaceSublayer occasionally crashes because the current layer doesn't have a superlayer. I believe this is a benign case that happens when we are restructuring the tree. But currently it crashes. I will add protection against the null pointer and see if this avoids any other problems.
Comment 1 Chris Marrin 2011-05-04 11:38:42 PDT 
rdar://problem/8751147
Comment 2 Chris Marrin 2011-05-04 11:41:41 PDT 
Created attachment 92290 [details]
Patch
Comment 3 Simon Fraser (smfr) 2011-05-04 11:43:38 PDT 
Comment on attachment 92290 [details]
Patch

You could leave the assertion in since it would be nice to know when this happens.
Comment 4 Chris Marrin 2011-05-04 13:17:53 PDT 
Committed r85781: <http://trac.webkit.org/changeset/85781>