Bug 60190 - Can't save a link from "Save Linked File to Download" popup menu
Summary: Can't save a link from "Save Linked File to Download" popup menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 11:32 PDT by Anders Carlsson
Modified: 2011-05-04 13:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (14.23 KB, patch)
2011-05-04 11:34 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2011-05-04 12:29 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-05-04 11:32:03 PDT
Can't save a link from "Save Linked File to Download" popup menu
Comment 1 Anders Carlsson 2011-05-04 11:34:19 PDT
Created attachment 92288 [details]
Patch
Comment 2 Early Warning System Bot 2011-05-04 11:43:45 PDT
Attachment 92288 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8557610
Comment 3 mitz 2011-05-04 11:45:55 PDT
Comment on attachment 92288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92288&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:639
> +    [request.get() setValue:(NSString*)webPage->userAgent() forHTTPHeaderField:@"User-Agent"];

Missing space after NSString
Comment 4 Build Bot 2011-05-04 12:26:53 PDT
Attachment 92288 [details] did not build on win:
Build output: http://queues.webkit.org/results/8577001
Comment 5 Anders Carlsson 2011-05-04 12:29:30 PDT
Created attachment 92299 [details]
Patch
Comment 6 Anders Carlsson 2011-05-04 13:33:56 PDT
Committed r85783: <http://trac.webkit.org/changeset/85783>