Bug 60180 - Including RenderLayerCompositor.h with USE(ACCELERATED_COMPOSITING) disabled causes compilation error.
Summary: Including RenderLayerCompositor.h with USE(ACCELERATED_COMPOSITING) disabled ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 09:41 PDT by Jer Noble
Modified: 2011-05-04 09:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-05-04 09:41:15 PDT 
RenderLayerCompositor inherits from GraphicsLayerClient, the definition of which is wrapped in a USE(ACCELERATED_COMPOSITING) conditional.  If RenderLayerCompositor is truly dependent on a class which is only available when that flag is enabled, the RenderLayerCompositor should be wrapped in a USE(ACCELERATED_COMPOSITING) conditional as well.
Comment 1 Simon Fraser (smfr) 2011-05-04 09:44:05 PDT 
RenderLayerCompositor.h should be included within guards. That's what we do everywhere.

#if USE(ACCELERATED_COMPOSITING)
#include "RenderLayerCompositor.h"
#endif
Comment 2 Simon Fraser (smfr) 2011-05-04 09:54:18 PDT 
Seems OK to wrap the header contents in guards.