WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
60180
Including RenderLayerCompositor.h with USE(ACCELERATED_COMPOSITING) disabled causes compilation error.
https://bugs.webkit.org/show_bug.cgi?id=60180
Summary
Including RenderLayerCompositor.h with USE(ACCELERATED_COMPOSITING) disabled ...
Jer Noble
Reported
2011-05-04 09:41:15 PDT
RenderLayerCompositor inherits from GraphicsLayerClient, the definition of which is wrapped in a USE(ACCELERATED_COMPOSITING) conditional. If RenderLayerCompositor is truly dependent on a class which is only available when that flag is enabled, the RenderLayerCompositor should be wrapped in a USE(ACCELERATED_COMPOSITING) conditional as well.
Attachments
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2011-05-04 09:44:05 PDT
RenderLayerCompositor.h should be included within guards. That's what we do everywhere. #if USE(ACCELERATED_COMPOSITING) #include "RenderLayerCompositor.h" #endif
Simon Fraser (smfr)
Comment 2
2011-05-04 09:54:18 PDT
Seems OK to wrap the header contents in guards.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug