Bug 60178 - webkit-patch build-attachment doesn't build
Summary: webkit-patch build-attachment doesn't build
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-04 09:32 PDT by David Kilzer (:ddkilzer)
Modified: 2011-05-04 12:41 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-05-04 09:32:55 PDT
$ ./Tools/Scripts/webkit-patch build-attachment --build-style=release --no-clean --no-update 92252
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to continue...
Logging in as ddkilzer@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=92252&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=59143&ctype=xml
Processing 1 patch from 1 bug.
Processing patch 92252 from bug 59143.
$
Comment 1 Eric Seidel (no email) 2011-05-04 09:37:27 PDT
I believe you have to pass the --build flag these days.  We should really fix that. :(
Comment 2 Adam Barth 2011-05-04 11:46:18 PDT
The "build" command shows how to do that.  build-attachment is a hidden command that's mostly just used internally.
Comment 3 David Kilzer (:ddkilzer) 2011-05-04 12:29:45 PDT
(In reply to comment #2)
> The "build" command shows how to do that.  build-attachment is a hidden command that's mostly just used internally.

I used "webkit-patch help --all" to find it.  The synopsis didn't warn about it being "internal-only" or requiring a --build argument to work.
Comment 4 Eric Seidel (no email) 2011-05-04 12:41:15 PDT
--all is a scary place!  But yes, our documentation should be made much much better. :(

There was some discussion at the advanced tool usage session about labeling some commands as "internal" or "experimental" now that more people are looking at --all.