Bug 60173 – [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Justin Novosad]

This is phase 2 of the delivery of the solution for https://bugs.webkit.org/show_bug.cgi?id=59929
This change will make the GPU accelerated 2D canvas lab use skia for rendering, which will likely require re-baselining several of the gpu layout test
and also adding additional failures to test_expectaions.txt for the unresolved issues.

[Justin Novosad]

Currently blocked on:
http://code.google.com/p/chromium/issues/detail?id=81674

[Justin Novosad]

Created attachment 92454 [details]
Patch

[Kenneth Russell]

Comment on attachment 92454 [details]
Patch

Thumbs up assuming it's been tested and won't turn the tree red. Please watch the canaries (see http://www.chromium.org/developers/how-tos/webkit-merge-1 ).

[Justin Novosad]

(In reply to comment #3)
> (From update of attachment 92454 [details])
> Thumbs up assuming it's been tested and won't turn the tree red. Please watch the canaries (see http://www.chromium.org/developers/how-tos/webkit-merge-1 ).

The try-bots came back clear on all platforms.

[James Robinson]

Did you run through the layout trybots (linux_layout, mac_layout, win_layout)?

[James Robinson]

http://build.chromium.org/p/tryserver.chromium/builders/linux_layout/builds/638 shows a lot of crashes on canvas tests

[Justin Novosad]

(In reply to comment #6)
> http://build.chromium.org/p/tryserver.chromium/builders/linux_layout/builds/638 shows a lot of crashes on canvas tests

No worries, that run did not have brian's fix in it.  I launched a new try with --revision=84277.  It came back clean on win_layout_rel.  Still haven't heard back from the debug bot though

[WebKit Commit Bot]

Comment on attachment 92454 [details]
Patch

Clearing flags on attachment: 92454

Committed r85895: <http://trac.webkit.org/changeset/85895>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.