Bug 60165 – [GTK] Unref the SoupSession used by WebKitGtk+ at exit

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[GTK] Unref the SoupSession used by WebKitGtk+ at exit

[Sergio Villar Senin]

Created attachment 92229 [details]
Patch

[Martin Robinson]

Comment on attachment 92229 [details]
Patch

Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this?

[Sergio Villar Senin]

(In reply to comment #2)
> (From update of attachment 92229 [details])
> Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this?

I understood that DEFINE_STATIC_LOCAL was used to avoid destructor calling on exit which is totally the contrary to what I'm trying to achieve. Maybe I'm not understanding what you mean...

[Martin Robinson]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 92229 [details] [details])
> > Have you looked at using DEFINE_STATIC_LOCAL and a GRefPtr to do this?
> 
> I understood that DEFINE_STATIC_LOCAL was used to avoid destructor calling on exit which is totally the contrary to what I'm trying to achieve. Maybe I'm not understanding what you mean...

It's used to avoid false leaks reporting on exit.

[Xan Lopez]

(In reply to comment #4)
> It's used to avoid false leaks reporting on exit.

From the macro documentation:

// Use these to declare and define a static local variable (static T;) so that
//  it is leaked so that its destructors are not called at exit. Using this
//  macro also allows workarounds a compiler bug present in Apple's version of GCC 4.0.1.

So it seems to me it does the opposite of what we want?

[Martin Robinson]

(In reply to comment #5)
> (In reply to comment #4)
> > It's used to avoid false leaks reporting on exit.
> 
> From the macro documentation:
> 
> // Use these to declare and define a static local variable (static T;) so that
> //  it is leaked so that its destructors are not called at exit. Using this
> //  macro also allows workarounds a compiler bug present in Apple's version of GCC 4.0.1.
> 
> So it seems to me it does the opposite of what we want?

Oh right. It seems so!

[Sergio Villar Senin]

Committed r87999: <http://trac.webkit.org/changeset/87999>