media/controls-css-overload.html is timing out on chromium bots

[Dirk Pranke]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fcontrols-css-overload.html&showExpectations=true&group=%40ToT%20-%20chromium.org

This issue is tracked in
http://code.google.com/p/chromium/issues/detail?id=80771

[Andrew Scherkus]

*** Bug 60941 has been marked as a duplicate of this bug. ***

[Steve Lacey]

Created attachment 95083 [details]
Patch

[Steve Lacey]

Created attachment 95084 [details]
Patch

[Steve Lacey]

Seems like there's a problem layoutTestController tickled by the behaviour of media/controls-after-reload.html.

Fixed the test (as it's behaviour was a little odd) and will create a chromium side bug on DRT.

[Eric Carlson]

Comment on attachment 95084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review

> LayoutTests/media/controls-after-reload.html:33
> +        video.src = findMediaFile("video", "content/test");
> +        video.load();

the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago.

[Steve Lacey]

Comment on attachment 95084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95084&action=review

>> LayoutTests/media/controls-after-reload.html:33

> 
> the video.load() is unnecessary and wasteful. load() used to be required after changing src, but the spec was changed so setting src triggers the load algorithm some time ago.

Agreed. It was in the original code - I'll remove it, and the one in test().

[Steve Lacey]

Created attachment 95187 [details]
Patch

[Eric Carlson]

Comment on attachment 95187 [details]
Patch

Thanks Steve!

[WebKit Commit Bot]

Comment on attachment 95187 [details]
Patch

Clearing flags on attachment: 95187

Committed r87583: <http://trac.webkit.org/changeset/87583>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.