Bug 60104 – [EFL] Fix build break after r85624

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Jaehun Lim]

After removing '-P' build option in r85624, EFL build breaks.
I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3).
First, I add '-P' again, but we need to find another way to remove '-P' option.

[Jaehun Lim]

Created attachment 92180 [details]
Proposed patch

[Jaehun Lim]

Created attachment 92181 [details]
Proposed patch

[Lucas De Marchi]

(In reply to comment #0)
> After removing '-P' build option in r85624, EFL build breaks.
> I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3).
> First, I add '-P' again, but we need to find another way to remove '-P' option.

What's the error message? 

For me it's broken with or without this patch, but with this patch it's a bit better

[Ryuan Choi]

(In reply to comment #3)
> (In reply to comment #0)
> > After removing '-P' build option in r85624, EFL build breaks.
> > I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3).
> > First, I add '-P' again, but we need to find another way to remove '-P' option.
> 
> What's the error message? 
> 
> For me it's broken with or without this patch, but with this patch it's a bit better

Below is messages.

/workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:66:66: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::strokeStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
/workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:72:79: error: no ‘void WebCore::JSCanvasRenderingContext2D::setStrokeStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
/workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:82:64: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::fillStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
/workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:88:77: error: no ‘void WebCore::JSCanvasRenderingContext2D::setFillStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
/workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:98:65: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::setFillColor(JSC::ExecState*)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’

BTW, does we need to add --preprocessor ?
Although removed, it looks fine.

[Lucas De Marchi]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > After removing '-P' build option in r85624, EFL build breaks.
> > > I think it makes some troubles for gcc < 4.6. (My gcc version is 4.4.3).
> > > First, I add '-P' again, but we need to find another way to remove '-P' option.
> > 
> > What's the error message? 
> > 
> > For me it's broken with or without this patch, but with this patch it's a bit better
> 
> Below is messages.
> 
> /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:66:66: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::strokeStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
> /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:72:79: error: no ‘void WebCore::JSCanvasRenderingContext2D::setStrokeStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
> /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:82:64: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::fillStyle(JSC::ExecState*) const’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
> /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:88:77: error: no ‘void WebCore::JSCanvasRenderingContext2D::setFillStyle(JSC::ExecState*, JSC::JSValue)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
> /workspace/webkit/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:98:65: error: no ‘JSC::JSValue WebCore::JSCanvasRenderingContext2D::setFillColor(JSC::ExecState*)’ member function declared in class ‘WebCore::JSCanvasRenderingContext2D’
> 
> BTW, does we need to add --preprocessor ?
> Although removed, it looks fine.


Humn... i think this is the problem. Maybe removing the  --preprocessor will do the job for all versions

[Gyuyoung Kim]

Comment on attachment 92181 [details]
Proposed patch

Lucas is going to land this patch directly.