Bug 60080 - Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Summary: Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 36921
  Show dependency treegraph
 
Reported: 2011-05-03 16:20 PDT by Eric Seidel (no email)
Modified: 2011-05-04 04:51 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.00 KB, patch)
2011-05-03 16:24 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (8.02 KB, patch)
2011-05-03 16:29 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (7.87 KB, patch)
2011-05-03 17:01 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-05-03 16:20:13 PDT
Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Comment 1 Eric Seidel (no email) 2011-05-03 16:24:08 PDT
Created attachment 92161 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-03 16:29:00 PDT
Created attachment 92163 [details]
Patch
Comment 3 Ryosuke Niwa 2011-05-03 16:58:58 PDT
Comment on attachment 92163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92163&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:930
> +            if (bidiRuns.runCount() && hyphenated)
> +                bidiRuns.logicallyLastRun()->m_hasHyphen = true;
> +
>              BidiRun* trailingSpaceRun = !lineInfo.previousLineBrokeCleanly() ? handleTrailingSpaces(bidiRuns, resolver.context()) : 0;

Are you certain that handleTrailingSpaces won't be affected by assigning the value to m_hasHyphen earlier?
Comment 4 Eric Seidel (no email) 2011-05-03 17:01:40 PDT
Created attachment 92172 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-05-04 04:49:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 92172 [details]:

http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2011-05-04 04:51:19 PDT
Comment on attachment 92172 [details]
Patch for landing

Clearing flags on attachment: 92172

Committed r85732: <http://trac.webkit.org/changeset/85732>
Comment 7 WebKit Commit Bot 2011-05-04 04:51:25 PDT
All reviewed patches have been landed.  Closing bug.