Bug 60080 – Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats

[Eric Seidel (no email)]

Created attachment 92161 [details]
Patch

[Eric Seidel (no email)]

Created attachment 92163 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 92163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92163&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:930
> +            if (bidiRuns.runCount() && hyphenated)
> +                bidiRuns.logicallyLastRun()->m_hasHyphen = true;
> +
>              BidiRun* trailingSpaceRun = !lineInfo.previousLineBrokeCleanly() ? handleTrailingSpaces(bidiRuns, resolver.context()) : 0;

Are you certain that handleTrailingSpaces won't be affected by assigning the value to m_hasHyphen earlier?

[Eric Seidel (no email)]

Created attachment 92172 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 92172 [details]:

http/tests/inspector/console-websocket-error.html bug 57392 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 92172 [details]
Patch for landing

Clearing flags on attachment: 92172

Committed r85732: <http://trac.webkit.org/changeset/85732>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.