RESOLVED FIXED 60049
[Qt] Fix signals emitted in FakeReply used in autotests 
https://bugs.webkit.org/show_bug.cgi?id=60049
Summary [Qt] Fix signals emitted in FakeReply used in autotests
Caio Marcelo de Oliveira Filho
Reported 2011-05-03 12:25:20 PDT
[Qt] Fix signals emitted in FakeReply used in autotests
Attachments
Patch (3.35 KB, patch)
2011-05-03 12:36 PDT, Caio Marcelo de Oliveira Filho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-05-03 12:36:03 PDT
Created attachment 92105 [details] Patch
Luiz Agostini
Comment 2 2011-05-03 13:06:04 PDT
Comment on attachment 92105 [details] Patch LGTM
Benjamin Poulain
Comment 3 2011-05-04 11:30:36 PDT
Comment on attachment 92105 [details] Patch make sense
WebKit Commit Bot
Comment 4 2011-05-04 12:00:55 PDT
Comment on attachment 92105 [details] Patch Clearing flags on attachment: 92105 Committed r85772: <http://trac.webkit.org/changeset/85772>
WebKit Commit Bot
Comment 5 2011-05-04 12:01:00 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-05-04 15:07:37 PDT
http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/navigation/response204.html
Caio Marcelo de Oliveira Filho
Comment 7 2011-05-04 15:50:01 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/85772 might have broken GTK Linux 64-bit Debug > The following tests are not passing: > http/tests/navigation/response204.html For the record: this patch only affects Qt autotests (small C++ programs that we use to test Qt API). So it's a "false alarm". PS: I'm not sure if it's helpful to add this kind of follow up.
Note You need to log in before you can comment on or make changes to this bug.