RESOLVED FIXED 60048
store results.html options in localstorage 
https://bugs.webkit.org/show_bug.cgi?id=60048
Summary store results.html options in localstorage
Ojan Vafai
Reported 2011-05-03 11:49:56 PDT
store results.html options in localstorage
Attachments
Patch (6.13 KB, patch)
2011-05-03 11:51 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-05-03 11:51:33 PDT
Created attachment 92098 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-03 12:03:17 PDT
Comment on attachment 92098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > LayoutTests/fast/harness/resources/results-test.js:65 > +function runTest(results, assertions, opt_localStorageValue) opt_? Funny prefix.
Ojan Vafai
Comment 3 2011-05-03 12:15:09 PDT
(In reply to comment #2) > (From update of attachment 92098 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review > > > LayoutTests/fast/harness/resources/results-test.js:65 > > +function runTest(results, assertions, opt_localStorageValue) > > opt_? Funny prefix. It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though.
Tony Chang
Comment 4 2011-05-03 13:37:32 PDT
Comment on attachment 92098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92098&action=review >>> LayoutTests/fast/harness/resources/results-test.js:65 >> >> opt_? Funny prefix. > > It's a convention I picked up from Google's JS code. I'm happy to remove the prefix or do something different. It's useful to be able to specify that an argument is optional though. The opt_ prefix seems fine considering we already checked in some code for it. We can discuss/change if we decide to have a JS style guide.
Ojan Vafai
Comment 5 2011-05-03 13:51:59 PDT
Committed r85654: <http://trac.webkit.org/changeset/85654>
Note You need to log in before you can comment on or make changes to this bug.