Bug 60041 - [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
Summary: [CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 11:01 PDT by Lucas De Marchi
Modified: 2011-07-14 02:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2011-05-03 11:03 PDT, Lucas De Marchi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2011-05-03 11:01:25 PDT 
[CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
Comment 1 Lucas De Marchi 2011-05-03 11:03:48 PDT 
Created attachment 92091 [details]
Patch
Comment 2 Xan Lopez 2011-05-03 11:14:18 PDT 
Comment on attachment 92091 [details]
Patch

Looks good to me!
Comment 3 Lucas De Marchi 2011-05-03 20:16:01 PDT 
Comment on attachment 92091 [details]
Patch

Clearing flags on attachment: 92091

Committed r85710: <http://trac.webkit.org/changeset/85710>
Comment 4 Lucas De Marchi 2011-05-03 20:16:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Keyon 2011-07-14 02:16:04 PDT 
why the patch is only added to Source/cmake/WebKitHelpers.cmake? I found the compling still failed on the 14.0.812.0 chromium, log as below:
  CXX(target) out/Release/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources01.o
In file included from third_party/WebKit/Source/JavaScriptCore/wtf/PassRefPtr.h:25:0,
                 from third_party/WebKit/Source/JavaScriptCore/wtf/CrossThreadRefCounted.h:35,
                 from third_party/WebKit/Source/JavaScriptCore/wtf/text/StringImpl.h:28,
                 from third_party/WebKit/Source/JavaScriptCore/wtf/text/WTFString.h:28,
                 from third_party/WebKit/Source/WebCore/platform/text/PlatformString.h:28,
                 from third_party/WebKit/Source/WebCore/loader/cache/CachedResource.h:28,
                 from third_party/WebKit/Source/WebCore/loader/cache/CachedResourceHandle.h:29,
                 from third_party/WebKit/Source/WebCore/dom/Clipboard.h:27,
                 from third_party/WebKit/Source/WebCore/dom/Event.h:27,
                 from third_party/WebKit/Source/WebCore/dom/BeforeProcessEvent.h:30,
                 from out/Release/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:24,
                 from out/Release/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22,
                 from out/Release/obj/gen/webkit/bindings/V8DerivedSources01.cpp:31:
third_party/WebKit/Source/JavaScriptCore/wtf/NullPtr.h:48:1: error:  identifier 'nullptr' will become a keyword in C++0x  [-Werror=c++0x-compat]


this patch is already there.