Bug 60040 - Links broken at iplanwebsites.com
Summary: Links broken at iplanwebsites.com
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2011-05-03 10:53 PDT by Dave Hyatt
Modified: 2011-05-03 11:18 PDT (History)
1 user (show)

See Also:

Patch (3.20 KB, patch)
2011-05-03 10:55 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-05-03 10:53:39 PDT
The links don't work because line box culling gives the wrong answer for a bounding client rect for empty links that get skipped as part of leading whitespace.
Comment 1 Dave Hyatt 2011-05-03 10:55:17 PDT
Comment 2 Dave Hyatt 2011-05-03 10:55:35 PDT
Created attachment 92090 [details]
Comment 3 mitz 2011-05-03 10:57:21 PDT
Comment on attachment 92090 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=92090&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Need a short description and bug URL (OOPS!)
> +
> +        No new tests. (OOPS!)

Please fill out the info here

> LayoutTests/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=60040

Would be nice to also have the Radar link here.
Comment 4 Dave Hyatt 2011-05-03 11:00:35 PDT
Fixed in r85623.
Comment 5 WebKit Review Bot 2011-05-03 11:18:33 PDT
Attachment 92090 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'Source/WebCore/C..." exit_code: 1

Source/WebCore/ChangeLog:5:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.