+++ This bug was initially created as a clone of Bug #58584 +++ Authors should be able to read and write the shadowPseudoId property on an element. A new LayoutTestController method is needed so test authors can get the shadowPseudoId of a given Node.
Created attachment 92258 [details] proposed patch I tested this on GTK, chromium-linux, qt-linux and mac. Not on windows though.
Attachment 92258 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1 Tools/DumpRenderTree/LayoutTestController.h:78: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 92259 [details] proposed patch
Comment on attachment 92259 [details] proposed patch This looks great! I think you're still missing changes to WebKitRunner for WebKit2?
(In reply to comment #4) > (From update of attachment 92259 [details]) > This looks great! I think you're still missing changes to WebKitRunner for WebKit2? Oh, true! I didn't know about that. New LayoutTestControllers to patch indeed :)
Comment on attachment 92259 [details] proposed patch Incomplete patch
Attachment 92259 [details] did not build on win: Build output: http://queues.webkit.org/results/8558556
Created attachment 92384 [details] proposed patch
Attachment 92384 [details] did not build on win: Build output: http://queues.webkit.org/results/8557859
Created attachment 92389 [details] proposed patch Trying to make win EWS happy about this.
Attachment 92389 [details] did not build on win: Build output: http://queues.webkit.org/results/8554845
(In reply to comment #11) > Attachment 92389 [details] did not build on win: > Build output: http://queues.webkit.org/results/8554845 Adam, would you mind checking my patch? It doesn't build on windows although I registered the new shadowPseudoId method in the IDOMElementPrivate interface... Not sure what to do about this and I don't have a windows box.
Created attachment 92397 [details] proposed patch Touched Source/WebKit/win/Interfaces/WebKit.idl in the secret hope this will trigger a magic rebuild in win EWS and turn the bubble to green!
(In reply to comment #13) > Created an attachment (id=92397) [details] > proposed patch > > Touched Source/WebKit/win/Interfaces/WebKit.idl > in the secret hope this will trigger a magic rebuild in win EWS and > turn the bubble to green! Sweet this worked \o/
Comment on attachment 92397 [details] proposed patch ok. Even though I am embarking on the journey to move these methods to window.internals, I am not going to block your progress on it.
Committed r85925: <http://trac.webkit.org/changeset/85925>