Bug 60031 - Web Inspector: can't inspect element in an iframe when element originates from non-frame document
Summary: Web Inspector: can't inspect element in an iframe when element originates fro...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
Depends on:
Reported: 2011-05-03 09:07 PDT by Yury Semikhatsky
Modified: 2011-05-03 23:45 PDT (History)
10 users (show)

See Also:

Patch (13.55 KB, patch)
2011-05-03 09:14 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff
Patch for landing (13.01 KB, patch)
2011-05-03 23:04 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-05-03 09:07:20 PDT
What steps will reproduce the problem?
1. Open http://kangax.github.com/jstests/iframe-createElement-web-inspector/
2. Try inspecting both elements in an iframe
3. One of the elements can't be inspected

This seems to be due to an element originating from context other than iframe's context (i.e. created via <main document>.createElement rather than <iframe document>.createElement).

Original Chromium bug report: http://code.google.com/p/chromium/issues/detail?id=77453
Comment 1 Yury Semikhatsky 2011-05-03 09:14:35 PDT
Created attachment 92084 [details]
Comment 2 Pavel Feldman 2011-05-03 10:05:30 PDT
Comment on attachment 92084 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=92084&action=review

> Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:102
> +        return jsBoolean(true);

return jsUndefined() ?
Comment 3 Yury Semikhatsky 2011-05-03 23:04:14 PDT
Created attachment 92196 [details]
Patch for landing

Review comments addressed.
Comment 4 Yury Semikhatsky 2011-05-03 23:45:59 PDT
Committed r85722: <http://trac.webkit.org/changeset/85722>