Bug 60015 - [Qt] Implement eventSender.scalePageBy
Summary: [Qt] Implement eventSender.scalePageBy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Fehér Zsolt
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-05-03 02:09 PDT by Csaba Osztrogonác
Modified: 2011-05-19 05:40 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (4.40 KB, patch)
2011-05-19 02:30 PDT, Fehér Zsolt
ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
proposed patch (5.72 KB, patch)
2011-05-19 03:52 PDT, Fehér Zsolt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-05-03 02:09:46 PDT
fast/transforms/selection-bounds-in-transformed-view.html needs it
Comment 1 Fehér Zsolt 2011-05-19 02:30:43 PDT
Created attachment 94052 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2011-05-19 02:50:01 PDT
Comment on attachment 94052 [details]
proposed patch

r-, because you should unskip the test fixed by this patch
Comment 3 Fehér Zsolt 2011-05-19 03:52:35 PDT
Created attachment 94058 [details]
proposed patch
Comment 4 Csaba Osztrogonác 2011-05-19 05:34:12 PDT
Comment on attachment 94058 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94058&action=review

LGTM, r=me with a little changelog fix.

> LayoutTests/ChangeLog:8
> +        * fast/transforms/selection-bounds-in-transformed-view.html: Removed.

It isn't true. :)

> LayoutTests/ChangeLog:9
> +        * platform/qt/Skipped::

Unskip fast/transforms/selection-bounds-in-transformed-view.html.
Comment 5 Csaba Osztrogonác 2011-05-19 05:40:27 PDT
Landed in http://trac.webkit.org/changeset/86841