Bug 60011 - Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
Summary: Remove redundant conversion from auto table layout to auto table layout in CS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-03 00:00 PDT by Luke Macpherson
Modified: 2011-05-04 04:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2011-05-03 00:01 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2011-05-03 16:55 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-05-03 00:00:34 PDT 
Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
Comment 1 Luke Macpherson 2011-05-03 00:01:59 PDT 
Created attachment 92051 [details]
Patch
Comment 2 Luke Macpherson 2011-05-03 00:03:18 PDT 
Removed code is analogous to if (x==y) x = y;
Comment 3 Darin Adler 2011-05-03 11:02:05 PDT 
Comment on attachment 92051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92051&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Can’t land this as is. You need to replace this line with an explanation of why this change doesn’t require new tests.
Comment 4 Luke Macpherson 2011-05-03 16:55:02 PDT 
Created attachment 92169 [details]
Patch
Comment 5 Luke Macpherson 2011-05-03 16:56:39 PDT 
Fixed ChangeLog entry.
Comment 6 Eric Seidel (no email) 2011-05-04 01:11:39 PDT 
Comment on attachment 92169 [details]
Patch

This code is obviously very old. :)
Comment 7 WebKit Commit Bot 2011-05-04 04:35:55 PDT 
Comment on attachment 92169 [details]
Patch

Clearing flags on attachment: 92169

Committed r85730: <http://trac.webkit.org/changeset/85730>
Comment 8 WebKit Commit Bot 2011-05-04 04:36:00 PDT 
All reviewed patches have been landed.  Closing bug.