Bug 60001 - REGRESSION(r84672): showTree doesn't work for input/textarea elements
Summary: REGRESSION(r84672): showTree doesn't work for input/textarea elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 52965
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-02 18:37 PDT by Ryosuke Niwa
Modified: 2011-05-02 19:26 PDT (History)
8 users (show)

See Also:

Attachments
fixes the bug (1.89 KB, patch)
2011-05-02 18:42 PDT, Ryosuke Niwa 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-05-02 18:37:40 PDT 
After http://trac.webkit.org/changeset/84672, calling showTreeForThis doesn't show the shadow DOM tree for input / textarea elements.
Comment 1 Ryosuke Niwa 2011-05-02 18:42:17 PDT 
Created attachment 92031 [details]
fixes the bug
Comment 2 Ryosuke Niwa 2011-05-02 18:46:52 PDT 
Committed r85572: <http://trac.webkit.org/changeset/85572>
Comment 3 Dimitri Glazkov (Google) 2011-05-02 19:18:40 PDT 
Hey that looks cool! I am pretty sure though that this isn't a regression. Prior to r84672, showTreeForThis was blissfully unaware of any kind of shadow DOM.
Comment 4 Ryosuke Niwa 2011-05-02 19:26:53 PDT 
(In reply to comment #3)
> Hey that looks cool! I am pretty sure though that this isn't a regression. Prior to r84672, showTreeForThis was blissfully unaware of any kind of shadow DOM.

Right but prior to r84672, the root node was div so we could still see the shadow tree if showTree was called on a shadow node.  However, after the change, we walk up the tree using parentOrHostNode, making it impossible to dump any shadow nodes for input/textarea.