Bug 59995 - Port Mozilla's IndexedDB tests: cursor update updates indexes
Summary: Port Mozilla's IndexedDB tests: cursor update updates indexes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-02 18:15 PDT by Mark Pilgrim (Google)
Modified: 2011-05-03 12:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.94 KB, patch)
2011-05-02 18:18 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (9.99 KB, patch)
2011-05-03 06:35 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-05-02 18:15:16 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_cursor_update_updates_indexes.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It checks that mutating records with a r/w cursor updates both unique and non-unique indexes on those records.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-05-02 18:18:00 PDT
Created attachment 92027 [details]
Patch
Comment 2 Hans Wennborg 2011-05-03 03:09:52 PDT
Comment on attachment 92027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92027&action=review

> LayoutTests/storage/indexeddb/mozilla/cursor-update-updates-indexes.html:44
> +    START_DATA = evalAndLog("START_DATA = 'hi';");

Hmm, START_DATA and END_DATA don't feel like WebKit-style names.


Looks good otherwise.
Comment 3 Mark Pilgrim (Google) 2011-05-03 06:35:03 PDT
Created attachment 92067 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2011-05-03 06:35:36 PDT
Updated variable names.
Comment 5 Hans Wennborg 2011-05-03 06:52:53 PDT
(In reply to comment #4)
> Updated variable names.

Unofficial r+.
Comment 6 WebKit Commit Bot 2011-05-03 12:11:49 PDT
Comment on attachment 92067 [details]
Patch

Clearing flags on attachment: 92067

Committed r85631: <http://trac.webkit.org/changeset/85631>
Comment 7 WebKit Commit Bot 2011-05-03 12:11:54 PDT
All reviewed patches have been landed.  Closing bug.